From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VBPUh-0000QL-Ni
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:27:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VBPUb-0006Zk-Pi
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:27:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VBPUb-0006Ze-ID
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:27:33 -0400
Message-ID: <52121DD8.9020506@redhat.com>
Date: Mon, 19 Aug 2013 15:30:00 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <52081254.597343.1376909324949.JavaMail.root@redhat.com>
	<52121014.8050108@suse.de>
In-Reply-To: <52121014.8050108@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Cc: Miroslav Rezanina <mrezanin@redhat.com>, qemu-devel@nongnu.org

On 08/19/13 14:31, Andreas F=C3=A4rber wrote:
> Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
>> usb-bt-dongle device can't be disabled as there's dependency in vl.c f=
ile. This patch add preprocesor condition to be able to disable it.
>=20
> Please limit to 76 chars per line (check `git log` output).
>=20
>>
>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>> ---
>>  hw/usb/Makefile.objs |  1 -
>>  vl.c                 | 18 ++++++++++++++----
>>  2 files changed, 14 insertions(+), 5 deletions(-)
>>
>> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
>> index f9695e7..8892ffd 100644
>> --- a/hw/usb/Makefile.objs
>> +++ b/hw/usb/Makefile.objs
>> @@ -20,7 +20,6 @@ common-obj-$(CONFIG_USB_SERIAL)       +=3D dev-seria=
l.o
>>  common-obj-$(CONFIG_USB_NETWORK)      +=3D dev-network.o
>> =20
>>  # FIXME: make configurable too
>> -CONFIG_USB_BLUETOOTH :=3D y
>=20
> You probably should delete the FIXME alongside?

What's everyone's opinion about CONFIG_USB_BLUETOOTH=3Dy disappearing fro=
m
the default build?

Thanks
Laszlo