From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBPv4-0005UT-Pc for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:55:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBPuy-0000Pz-Jx for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:54:54 -0400 Message-ID: <521223A4.2010205@suse.de> Date: Mon, 19 Aug 2013 15:54:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1376891726-26122-1-git-send-email-aik@ozlabs.ru> <1376891726-26122-3-git-send-email-aik@ozlabs.ru> In-Reply-To: <1376891726-26122-3-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/8] xics: add pre_save/post_load/cpu_setup dispatchers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Paul Mackerras , qemu-ppc@nongnu.org, David Gibson Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy: > The upcoming support of in-kernel XICS will redefine migration callback= s > for both ICS and ICP so classes and callback pointers are added. >=20 > This adds a cpu_setup callback to the XICS device class (as XICS-KVM > will do it different) and xics_dispatch_cpu_setup(). This also moves > the place where xics_dispatch_cpu_setup() is called a bit further to > have VCPU initialized (required for XICS-KVM). >=20 > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v3: > * fixed local variables names > --- > hw/intc/xics.c | 61 +++++++++++++++++++++++++++++++++++++++++++= ++++---- > hw/ppc/spapr.c | 4 ++-- > include/hw/ppc/xics.h | 46 +++++++++++++++++++++++++++++++++++++- > 3 files changed, 104 insertions(+), 7 deletions(-) >=20 > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > index 6b3c071..e3a957d 100644 > --- a/hw/intc/xics.c > +++ b/hw/intc/xics.c [...] > @@ -674,10 +724,12 @@ static Property xics_properties[] =3D { > static void xics_class_init(ObjectClass *oc, void *data) > { > DeviceClass *dc =3D DEVICE_CLASS(oc); > + XICSStateClass *k =3D XICS_CLASS(oc); > =20 > dc->realize =3D xics_realize; > dc->props =3D xics_properties; > dc->reset =3D xics_reset; > + k->cpu_setup =3D xics_cpu_setup; > =20 > spapr_rtas_register("ibm,set-xive", rtas_set_xive); > spapr_rtas_register("ibm,get-xive", rtas_get_xive); This hunk is fixed up in 4/8, please squash that bit here. Otherwise looks good. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg