From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBPzN-0008Pq-JH for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:59:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBPzH-0002Cb-LE for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:59:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBPzH-0002CS-Dt for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:59:15 -0400 Message-ID: <52122489.7050307@redhat.com> Date: Mon, 19 Aug 2013 15:58:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <52081254.597343.1376909324949.JavaMail.root@redhat.com> <52121014.8050108@suse.de> <52121DD8.9020506@redhat.com> <5212207A.9010408@suse.de> In-Reply-To: <5212207A.9010408@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Miroslav Rezanina , Laszlo Ersek , Gerd Hoffmann , qemu-devel@nongnu.org Il 19/08/2013 15:41, Andreas F=C3=A4rber ha scritto: > By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearing, > check default-configs/usb.mak. All targets that include usb.mak will > have CONFIG_USB_BLUETOOTH. >=20 > It's only used in the build system and with this patch in vl.c, so > assuming that Miroslav has checked that the build succeeds for all > targets, this should be fine, I guess. Actually, CONFIG_* symbols for devices are _not_ exposed to vl.c. Blue Swirl specifically wanted that to happen. So I'm afraid Mirek's patch breaks "-usb bt" even if CONFIG_USB_BLUETOOTH is set to y. Paolo