[Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Erik Rull]

Hi all,

when using the released qemu-1.6.0.tar.bz2, I get the following error message:

[...]
ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
  GEN   qemu-options.def
  GEN   qmp-commands.h
Traceback (most recent call last):
  File "/home/erik/qemu-1.6.0/scripts/qapi-commands.py", line 14, in <module>
    from qapi import *
  File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
    except QAPISchemaError as e:
                            ^
SyntaxError: invalid syntax
make: *** [qmp-commands.h] Error 1

Any ideas how to fix that?

Thanks.

Best regards,

Erik

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Luiz Capitulino]

On Fri, 16 Aug 2013 09:59:24 +0200 (CEST)
Erik Rull <erik.rull@rdsoftware.de> wrote:

> Hi all,
> 
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> 
> [...]
> ar: creating libfdt/libfdt.a
> a - libfdt/fdt.o
> a - libfdt/fdt_ro.o
> a - libfdt/fdt_wip.o
> a - libfdt/fdt_sw.o
> a - libfdt/fdt_rw.o
> a - libfdt/fdt_strerror.o
>   GEN   qemu-options.def
>   GEN   qmp-commands.h
> Traceback (most recent call last):
>   File "/home/erik/qemu-1.6.0/scripts/qapi-commands.py", line 14, in <module>
>     from qapi import *
>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>     except QAPISchemaError as e:
>                             ^
> SyntaxError: invalid syntax
> make: *** [qmp-commands.h] Error 1
> 
> Any ideas how to fix that?

I can't reproduce it. What's your configure line?

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Peter Maydell]

On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> Hi all,
>
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>     except QAPISchemaError as e:
>                             ^
> SyntaxError: invalid syntax
> make: *** [qmp-commands.h] Error 1

My guess is that your python is older than 2.6; I think
the "except Foo as e" syntax is new in 2.6. We probably
missed this because most people use a newer Python than
2.6, but configure's check only requires 2.4 or better.

We should probably update the scripts to not use overly
new features (or alternatively decide that 2.6 is our new
minimum -- what do RHEL5 and our other oldest-supported
distros ship?)

For this specific case I think it needs to change to
     except QAPISchemaError, e:

thanks
-- PMM

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Luiz Capitulino]

On Fri, 16 Aug 2013 14:21:50 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> > Hi all,
> >
> > when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> >   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >     except QAPISchemaError as e:
> >                             ^
> > SyntaxError: invalid syntax
> > make: *** [qmp-commands.h] Error 1
> 
> My guess is that your python is older than 2.6; I think
> the "except Foo as e" syntax is new in 2.6. We probably
> missed this because most people use a newer Python than
> 2.6, but configure's check only requires 2.4 or better.
> 
> We should probably update the scripts to not use overly
> new features (or alternatively decide that 2.6 is our new
> minimum -- what do RHEL5 and our other oldest-supported
> distros ship?)
> 
> For this specific case I think it needs to change to
>      except QAPISchemaError, e:

Erik, can you try that and post a patch? Would be interesting
to know if this is the only problem with older python.

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Erik Rull]

Luiz Capitulino wrote:
> On Fri, 16 Aug 2013 14:21:50 +0100
> Peter Maydell <peter.maydell@linaro.org> wrote:
>
>> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
>>> Hi all,
>>>
>>> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>>>    File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>>>      except QAPISchemaError as e:
>>>                              ^
>>> SyntaxError: invalid syntax
>>> make: *** [qmp-commands.h] Error 1
>>
>> My guess is that your python is older than 2.6; I think
>> the "except Foo as e" syntax is new in 2.6. We probably
>> missed this because most people use a newer Python than
>> 2.6, but configure's check only requires 2.4 or better.
>>
>> We should probably update the scripts to not use overly
>> new features (or alternatively decide that 2.6 is our new
>> minimum -- what do RHEL5 and our other oldest-supported
>> distros ship?)
>>
>> For this specific case I think it needs to change to
>>       except QAPISchemaError, e:
>
> Erik, can you try that and post a patch? Would be interesting
> to know if this is the only problem with older python.
>

Yes, I will try that. I never really tried to send patches to this list...
My python version is 2.4 - as it was assumed already.

Best regards,

Erik

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Erik Rull]

> On August 19, 2013 at 6:15 PM Erik Rull <erik.rull@rdsoftware.de> wrote:
>
>
> Luiz Capitulino wrote:
> > On Fri, 16 Aug 2013 14:21:50 +0100
> > Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> >> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> >>> Hi all,
> >>>
> >>> when using the released qemu-1.6.0.tar.bz2, I get the following error
> >>> message:
> >>>    File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >>>      except QAPISchemaError as e:
> >>>                              ^
> >>> SyntaxError: invalid syntax
> >>> make: *** [qmp-commands.h] Error 1
> >>
> >> My guess is that your python is older than 2.6; I think
> >> the "except Foo as e" syntax is new in 2.6. We probably
> >> missed this because most people use a newer Python than
> >> 2.6, but configure's check only requires 2.4 or better.
> >>
> >> We should probably update the scripts to not use overly
> >> new features (or alternatively decide that 2.6 is our new
> >> minimum -- what do RHEL5 and our other oldest-supported
> >> distros ship?)
> >>
> >> For this specific case I think it needs to change to
> >>       except QAPISchemaError, e:
> >
> > Erik, can you try that and post a patch? Would be interesting
> > to know if this is the only problem with older python.
> >
>
> Yes, I will try that. I never really tried to send patches to this list...
> My python version is 2.4 - as it was assumed already.
>
> Best regards,
>
> Erik

This "fixes" it - it compiles successfully, but my guest no longer boots up
completely!
Windows XP gets a bluescreen and reboots in an infinite loop. Strange is: I was
requested to put some "efi*" files now on my target system for handling the
network cards (qemu complains at startup via stderr when I don't have them
available on my target system). But why? Where can I select to use the "pxe*"
files? There seems to be no possibility to select them via ./configure or as
qemu command line option. Maybe this is related to the bluescreen? 1.2.0 was
working properly.

Best regards,

Erik

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Andreas Färber]

Am 16.08.2013 15:21, schrieb Peter Maydell:
> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
>> Hi all,
>>
>> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>>     except QAPISchemaError as e:
>>                             ^
>> SyntaxError: invalid syntax
>> make: *** [qmp-commands.h] Error 1
> 
> My guess is that your python is older than 2.6; I think
> the "except Foo as e" syntax is new in 2.6. We probably
> missed this because most people use a newer Python than
> 2.6, but configure's check only requires 2.4 or better.
> 
> We should probably update the scripts to not use overly
> new features (or alternatively decide that 2.6 is our new
> minimum -- what do RHEL5 and our other oldest-supported
> distros ship?)

I vaguely remember running into such problems before... possibly on
Solaris. We compiled a list of Python versions and I think settled for
2.4 based on some old RHEL, too. CC'ing Stefan.

git-blame points to:
http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd37c3?f=configure

Andreas

> 
> For this specific case I think it needs to change to
>      except QAPISchemaError, e:
> 
> thanks
> -- PMM
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Stefan Hajnoczi]

On Mon, Aug 19, 2013 at 03:50:45PM +0200, Andreas Färber wrote:
> Am 16.08.2013 15:21, schrieb Peter Maydell:
> > On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> >> Hi all,
> >>
> >> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> >>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >>     except QAPISchemaError as e:
> >>                             ^
> >> SyntaxError: invalid syntax
> >> make: *** [qmp-commands.h] Error 1
> > 
> > My guess is that your python is older than 2.6; I think
> > the "except Foo as e" syntax is new in 2.6. We probably
> > missed this because most people use a newer Python than
> > 2.6, but configure's check only requires 2.4 or better.
> > 
> > We should probably update the scripts to not use overly
> > new features (or alternatively decide that 2.6 is our new
> > minimum -- what do RHEL5 and our other oldest-supported
> > distros ship?)
> 
> I vaguely remember running into such problems before... possibly on
> Solaris. We compiled a list of Python versions and I think settled for
> 2.4 based on some old RHEL, too. CC'ing Stefan.
> 
> git-blame points to:
> http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd37c3?f=configure

Yes, we should write Python 2.4+ code so that even oldish distros can
execute our scripts.

Stefan

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Markus Armbruster]

Erik Rull <erik.rull@rdsoftware.de> writes:

> Hi all,
>
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>
> [...]
> ar: creating libfdt/libfdt.a
> a - libfdt/fdt.o
> a - libfdt/fdt_ro.o
> a - libfdt/fdt_wip.o
> a - libfdt/fdt_sw.o
> a - libfdt/fdt_rw.o
> a - libfdt/fdt_strerror.o
>   GEN   qemu-options.def
>   GEN   qmp-commands.h
> Traceback (most recent call last):
>   File "/home/erik/qemu-1.6.0/scripts/qapi-commands.py", line 14, in <module>
>     from qapi import *
>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>     except QAPISchemaError as e:
>                             ^
> SyntaxError: invalid syntax
> make: *** [qmp-commands.h] Error 1
>
> Any ideas how to fix that?

Output of "python --version", please.  Make sure to use the same python
as the build process (grep PYTHON config-host.mak).