From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBVdq-00006D-AF for qemu-devel@nongnu.org; Mon, 19 Aug 2013 16:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBVdh-00008R-Ty for qemu-devel@nongnu.org; Mon, 19 Aug 2013 16:01:30 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:36019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBVdh-00008G-Of for qemu-devel@nongnu.org; Mon, 19 Aug 2013 16:01:21 -0400 Received: by mail-ee0-f41.google.com with SMTP id d17so2356579eek.14 for ; Mon, 19 Aug 2013 13:01:20 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52127964.3070102@redhat.com> Date: Mon, 19 Aug 2013 22:00:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1376937210-21394-1-git-send-email-ncmike@ncultra.org> <87d2p9ik4z.fsf@pixel.localdomain> In-Reply-To: <87d2p9ik4z.fsf@pixel.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object oriented casts with runtime checking semantics. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day Cc: Peter Maydell , qemu-devel@nongnu.org Il 19/08/2013 20:57, Mike Day ha scritto: >>> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c >>> >> index ebcb52a..46d8c27 100644 >>> >> --- a/hw/misc/ivshmem.c >>> >> +++ b/hw/misc/ivshmem.c >>> >> @@ -789,7 +789,7 @@ static void pci_ivshmem_uninit(PCIDevice *dev) >>> >> >>> >> static void pci_ivshmem_instance_finalize(Object *obj) >>> >> { >>> >> - IVShmemState *s = IVSHMEM(dev); >>> >> + IVShmemState *s = IVSHMEM(obj); >> > >> > This should have been a flat-out compiler error, right? > Yes, correct, but Paolo hasn't previously submitted this specific change > code afaik. > Yes, it's just a conflict resolution pasto. I squashed the changes into the branch. Paolo