From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 15/27] target/microblaze: Re-indent print_insn_microblaze
Date: Mon, 3 Jun 2024 12:14:45 -0700 [thread overview]
Message-ID: <521297e9-e93a-4c6d-827f-45c62e814ec0@linaro.org> (raw)
In-Reply-To: <20240412073346.458116-16-richard.henderson@linaro.org>
On 4/12/24 00:33, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> disas/microblaze.c | 263 ++++++++++++++++++++++++---------------------
> 1 file changed, 141 insertions(+), 122 deletions(-)
>
> diff --git a/disas/microblaze.c b/disas/microblaze.c
> index 3473c94164..c729c76585 100644
> --- a/disas/microblaze.c
> +++ b/disas/microblaze.c
> @@ -787,134 +787,153 @@ static void print_immval_addr(struct disassemble_info *info, bool immfound,
> }
>
> int
> -print_insn_microblaze (bfd_vma memaddr, struct disassemble_info * info)
> +print_insn_microblaze(bfd_vma memaddr, struct disassemble_info *info)
> {
> - fprintf_function fprintf_func = info->fprintf_func;
> - void * stream = info->stream;
> - unsigned long inst, prev_inst;
> - const struct op_code_struct *op, *pop;
> - int immval = 0;
> - bfd_boolean immfound = FALSE;
> - static bfd_vma prev_insn_addr = -1; /*init the prev insn addr */
> - static int prev_insn_vma = -1; /*init the prev insn vma */
> - int curr_insn_vma = info->buffer_vma;
> + fprintf_function fprintf_func = info->fprintf_func;
> + void *stream = info->stream;
> + unsigned long inst, prev_inst;
> + const struct op_code_struct *op, *pop;
> + int immval = 0;
> + bool immfound = false;
> + static bfd_vma prev_insn_addr = -1; /*init the prev insn addr */
> + static int prev_insn_vma = -1; /*init the prev insn vma */
> + int curr_insn_vma = info->buffer_vma;
>
> - info->bytes_per_chunk = 4;
> + info->bytes_per_chunk = 4;
>
> - inst = read_insn_microblaze (memaddr, info, &op);
> - if (inst == 0) {
> - return -1;
> - }
> + inst = read_insn_microblaze (memaddr, info, &op);
> + if (inst == 0) {
> + return -1;
> + }
>
> - if (prev_insn_vma == curr_insn_vma) {
> - if (memaddr-(info->bytes_per_chunk) == prev_insn_addr) {
> - prev_inst = read_insn_microblaze (prev_insn_addr, info, &pop);
> - if (prev_inst == 0)
> - return -1;
> - if (pop->instr == imm) {
> - immval = (get_int_field_imm(prev_inst) << 16) & 0xffff0000;
> - immfound = TRUE;
> + if (prev_insn_vma == curr_insn_vma) {
> + if (memaddr - info->bytes_per_chunk == prev_insn_addr) {
> + prev_inst = read_insn_microblaze (prev_insn_addr, info, &pop);
> + if (prev_inst == 0)
> + return -1;
> + if (pop->instr == imm) {
> + immval = (get_int_field_imm(prev_inst) << 16) & 0xffff0000;
> + immfound = TRUE;
> + }
> + else {
> + immval = 0;
> + immfound = FALSE;
> + }
> + }
> }
> - else {
> - immval = 0;
> - immfound = FALSE;
> - }
> - }
> - }
> - /* make curr insn as prev insn */
> - prev_insn_addr = memaddr;
> - prev_insn_vma = curr_insn_vma;
> + /* make curr insn as prev insn */
> + prev_insn_addr = memaddr;
> + prev_insn_vma = curr_insn_vma;
>
> - if (op->name == 0) {
> - fprintf_func (stream, ".short 0x%04lx", inst);
> - }
> - else
> - {
> - fprintf_func (stream, "%s", op->name);
> + if (op->name == 0) {
> + fprintf_func (stream, ".short 0x%04lx", inst);
> + return 4;
> + }
> +
> + fprintf_func (stream, "%s", op->name);
>
> - switch (op->inst_type)
> - {
> - case INST_TYPE_RD_R1_R2:
> - fprintf_func(stream, "\t%s, %s, %s", get_field_rd(inst), get_field_r1(inst), get_field_r2(inst));
> - break;
> - case INST_TYPE_RD_R1_IMM:
> - fprintf_func(stream, "\t%s, %s, %s", get_field_rd(inst), get_field_r1(inst), get_field_imm(inst));
> - if (get_int_field_r1(inst) == 0) {
> - print_immval_addr(info, immfound, immval, inst, 0);
> - }
> - break;
> - case INST_TYPE_RD_R1_IMM5:
> - fprintf_func(stream, "\t%s, %s, %s", get_field_rd(inst), get_field_r1(inst), get_field_imm5(inst));
> - break;
> - case INST_TYPE_RD_RFSL:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_rfsl(inst));
> - break;
> - case INST_TYPE_R1_RFSL:
> - fprintf_func(stream, "\t%s, %s", get_field_r1(inst), get_field_rfsl(inst));
> - break;
> - case INST_TYPE_RD_SPECIAL:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_special(inst, op));
> - break;
> - case INST_TYPE_SPECIAL_R1:
> - fprintf_func(stream, "\t%s, %s", get_field_special(inst, op), get_field_r1(inst));
> - break;
> - case INST_TYPE_RD_R1:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_r1(inst));
> - break;
> - case INST_TYPE_R1_R2:
> - fprintf_func(stream, "\t%s, %s", get_field_r1(inst), get_field_r2(inst));
> - break;
> - case INST_TYPE_R1_IMM:
> - fprintf_func(stream, "\t%s, %s", get_field_r1(inst), get_field_imm(inst));
> - /* The non-pc relative instructions are returns, which shouldn't
> - have a label printed */
> - if (op->inst_offset_type == INST_PC_OFFSET) {
> - print_immval_addr(info, immfound, immval, inst, memaddr);
> - }
> - break;
> - case INST_TYPE_RD_IMM:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_imm(inst));
> - print_immval_addr(info, immfound, immval, inst,
> - op->inst_offset_type == INST_PC_OFFSET
> - ? memaddr : 0);
> - break;
> - case INST_TYPE_IMM:
> - fprintf_func(stream, "\t%s", get_field_imm(inst));
> - if (op->instr != imm) {
> - print_immval_addr(info, immfound, immval, inst,
> - op->inst_offset_type == INST_PC_OFFSET
> - ? memaddr : 0);
> - }
> - break;
> - case INST_TYPE_RD_R2:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_r2(inst));
> - break;
> - case INST_TYPE_R2:
> - fprintf_func(stream, "\t%s", get_field_r2(inst));
> - break;
> - case INST_TYPE_R1:
> - fprintf_func(stream, "\t%s", get_field_r1(inst));
> - break;
> - case INST_TYPE_RD_R1_SPECIAL:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_r2(inst));
> - break;
> - case INST_TYPE_RD_IMM15:
> - fprintf_func(stream, "\t%s, %s", get_field_rd(inst), get_field_imm15(inst));
> - break;
> - /* For tuqula instruction */
> - case INST_TYPE_RD:
> - fprintf_func(stream, "\t%s", get_field_rd(inst));
> - break;
> - case INST_TYPE_RFSL:
> - fprintf_func(stream, "\t%s", get_field_rfsl(inst));
> - break;
> - default:
> - /* if the disassembler lags the instruction set */
> - fprintf_func (stream, "\tundecoded operands, inst is 0x%04lx", inst);
> - break;
> - }
> + switch (op->inst_type) {
> + case INST_TYPE_RD_R1_R2:
> + fprintf_func(stream, "\t%s, %s, %s",
> + get_field_rd(inst), get_field_r1(inst),
> + get_field_r2(inst));
> + break;
> + case INST_TYPE_RD_R1_IMM:
> + fprintf_func(stream, "\t%s, %s, %s",
> + get_field_rd(inst), get_field_r1(inst),
> + get_field_imm(inst));
> + if (get_int_field_r1(inst) == 0) {
> + print_immval_addr(info, immfound, immval, inst, 0);
> + }
> + break;
> + case INST_TYPE_RD_R1_IMM5:
> + fprintf_func(stream, "\t%s, %s, %s",
> + get_field_rd(inst), get_field_r1(inst),
> + get_field_imm5(inst));
> + break;
> + case INST_TYPE_RD_RFSL:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_rfsl(inst));
> + break;
> + case INST_TYPE_R1_RFSL:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_r1(inst), get_field_rfsl(inst));
> + break;
> + case INST_TYPE_RD_SPECIAL:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_special(inst, op));
> + break;
> + case INST_TYPE_SPECIAL_R1:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_special(inst, op), get_field_r1(inst));
> + break;
> + case INST_TYPE_RD_R1:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_r1(inst));
> + break;
> + case INST_TYPE_R1_R2:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_r1(inst), get_field_r2(inst));
> + break;
> + case INST_TYPE_R1_IMM:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_r1(inst), get_field_imm(inst));
> + /*
> + * The non-pc relative instructions are returns,
> + * which shouldn't have a label printed.
> + */
> + if (op->inst_offset_type == INST_PC_OFFSET) {
> + print_immval_addr(info, immfound, immval, inst, memaddr);
> + }
> + break;
> + case INST_TYPE_RD_IMM:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_imm(inst));
> + print_immval_addr(info, immfound, immval, inst,
> + op->inst_offset_type == INST_PC_OFFSET
> + ? memaddr : 0);
> + break;
> + case INST_TYPE_IMM:
> + fprintf_func(stream, "\t%s", get_field_imm(inst));
> + if (op->instr != imm) {
> + print_immval_addr(info, immfound, immval, inst,
> + op->inst_offset_type == INST_PC_OFFSET
> + ? memaddr : 0);
> + }
> + break;
> + case INST_TYPE_RD_R2:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_r2(inst));
> + break;
> + case INST_TYPE_R2:
> + fprintf_func(stream, "\t%s",
> + get_field_r2(inst));
> + break;
> + case INST_TYPE_R1:
> + fprintf_func(stream, "\t%s",
> + get_field_r1(inst));
> + break;
> + case INST_TYPE_RD_R1_SPECIAL:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_r2(inst));
> + break;
> + case INST_TYPE_RD_IMM15:
> + fprintf_func(stream, "\t%s, %s",
> + get_field_rd(inst), get_field_imm15(inst));
> + break;
> + /* For tuqula instruction */
> + case INST_TYPE_RD:
> + fprintf_func(stream, "\t%s",
> + get_field_rd(inst));
> + break;
> + case INST_TYPE_RFSL:
> + fprintf_func(stream, "\t%s",
> + get_field_rfsl(inst));
> + break;
> + default:
> + /* if the disassembler lags the instruction set */
> + fprintf_func(stream, "\tundecoded operands, inst is 0x%04lx", inst);
> + break;
> }
> -
> - /* Say how many bytes we consumed? */
> - return 4;
> + return 4;
> }
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2024-06-03 19:15 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 7:33 [PATCH v3 00/27] misc: Replace sprintf Richard Henderson
2024-04-12 7:33 ` [PATCH v3 01/27] util/hexdump: Remove b parameter from qemu_hexdump_line Richard Henderson
2024-04-12 10:00 ` Philippe Mathieu-Daudé
2024-06-03 19:40 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 02/27] util/hexdump: Remove ascii " Richard Henderson
2024-04-12 10:03 ` Philippe Mathieu-Daudé
2024-06-03 17:42 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 03/27] util/hexdump: Use a GString for qemu_hexdump_line Richard Henderson
2024-04-12 17:41 ` Philippe Mathieu-Daudé
2024-04-12 18:59 ` Richard Henderson
2024-04-13 9:45 ` Philippe Mathieu-Daudé
2024-04-13 12:02 ` Stefan Hajnoczi
2024-04-12 7:33 ` [PATCH v3 04/27] util/hexdump: Add unit_len and block_len to qemu_hexdump_line Richard Henderson
2024-04-12 17:42 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x" Richard Henderson
2024-04-12 17:43 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 06/27] hw/mips/malta: Add re-usable rng_seed_hex_new() method Richard Henderson
2024-06-03 18:56 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 07/27] system/qtest: Replace sprintf by qemu_hexdump_line Richard Henderson
2024-04-12 17:45 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf Richard Henderson
2024-04-12 17:45 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 09/27] hw/ide/atapi: " Richard Henderson
2024-06-03 18:57 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 10/27] hw/dma/pl330: " Richard Henderson
2024-06-03 18:59 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 11/27] backends/tpm: " Richard Henderson
2024-04-12 17:47 ` Philippe Mathieu-Daudé
2024-04-12 7:33 ` [PATCH v3 12/27] disas/m68k: Replace sprintf() by snprintf() Richard Henderson
2024-04-12 7:33 ` [PATCH v3 13/27] disas/microblaze: " Richard Henderson
2024-04-12 7:33 ` [PATCH v3 14/27] disas/microblaze: Split out print_immval_addr Richard Henderson
2024-06-03 19:14 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 15/27] target/microblaze: Re-indent print_insn_microblaze Richard Henderson
2024-06-03 19:14 ` Pierrick Bouvier [this message]
2024-04-12 7:33 ` [PATCH v3 16/27] disas/microblaze: Merge op->name output into each fprintf Richard Henderson
2024-06-03 19:15 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg Richard Henderson
2024-06-03 19:17 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 18/27] disas/microblaze: Print immediates directly with PRIimm Richard Henderson
2024-06-03 19:17 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 19/27] disas/microblaze: Print registers directly with PRIrfsl Richard Henderson
2024-06-03 19:17 ` Pierrick Bouvier
2024-06-03 19:18 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 20/27] disas/microblaze: Split get_field_special Richard Henderson
2024-06-03 19:20 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 21/27] disas/riscv: Use GString in format_inst Richard Henderson
2024-06-03 19:24 ` Pierrick Bouvier
2024-06-04 0:15 ` Alistair Francis
2024-04-12 7:33 ` [PATCH v3 22/27] linux-user/flatload: Replace sprintf() by snprintf() Richard Henderson
2024-04-12 9:48 ` Peter Maydell
2024-06-03 19:02 ` Pierrick Bouvier
2024-04-12 7:33 ` [PATCH v3 23/27] hw/misc/imx: " Richard Henderson
2024-04-12 7:33 ` [PATCH v3 24/27] hw/net/rocker: " Richard Henderson
2024-04-12 10:58 ` Philippe Mathieu-Daudé
2024-04-12 14:51 ` Richard Henderson
2024-04-12 7:33 ` [PATCH v3 25/27] hw/riscv/virt: Replace sprintf by g_strdup_printf Richard Henderson
2024-06-03 19:06 ` Pierrick Bouvier
2024-06-04 0:16 ` Alistair Francis
2024-04-12 7:33 ` [PATCH v3 26/27] target/arm: Replace sprintf() by snprintf() Richard Henderson
2024-04-12 7:33 ` [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings Richard Henderson
2024-04-12 10:59 ` Philippe Mathieu-Daudé
2024-04-16 15:32 ` Peter Maydell
2024-04-16 15:32 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521297e9-e93a-4c6d-827f-45c62e814ec0@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).