From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Luiz Capitulino <lcapitul@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message
Date: Tue, 20 Aug 2013 07:40:25 -0600 [thread overview]
Message-ID: <521371C9.6020800@redhat.com> (raw)
In-Reply-To: <1376967501-23886-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On 08/19/2013 08:58 PM, Fam Zheng wrote:
> It's more friendly to print which char is invalid to user, especially
> when user tries to input a float value and expect the monitor to round
> it to int. Since we don't round float number when we look for a integer,
> telling which char is invalid is less confusing.
Including a sample of the error message issued before and after this
patch as part of the commit message is helpful, but not enough for me to
require a respin.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> monitor.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-20 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:58 [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message Fam Zheng
2013-08-20 7:09 ` Markus Armbruster
2013-08-20 13:40 ` Eric Blake [this message]
2013-08-20 14:26 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521371C9.6020800@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=lcapitul@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).