From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBmAi-0007Qd-Kb for qemu-devel@nongnu.org; Tue, 20 Aug 2013 09:40:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBmAd-0001gu-JI for qemu-devel@nongnu.org; Tue, 20 Aug 2013 09:40:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBmAd-0001gh-9l for qemu-devel@nongnu.org; Tue, 20 Aug 2013 09:40:27 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7KDeQBN019813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Aug 2013 09:40:26 -0400 Message-ID: <521371C9.6020800@redhat.com> Date: Tue, 20 Aug 2013 07:40:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376967501-23886-1-git-send-email-famz@redhat.com> In-Reply-To: <1376967501-23886-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pL6bkJP1sqToQaub1XnEmF2LFsxdjcwaJ" Subject: Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Luiz Capitulino , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pL6bkJP1sqToQaub1XnEmF2LFsxdjcwaJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/19/2013 08:58 PM, Fam Zheng wrote: > It's more friendly to print which char is invalid to user, especially > when user tries to input a float value and expect the monitor to round > it to int. Since we don't round float number when we look for a integer= , > telling which char is invalid is less confusing. Including a sample of the error message issued before and after this patch as part of the commit message is helpful, but not enough for me to require a respin. >=20 > Signed-off-by: Fam Zheng > --- > monitor.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pL6bkJP1sqToQaub1XnEmF2LFsxdjcwaJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSE3HJAAoJEKeha0olJ0NqoCIH/2s4JQ9p3Icue5vYlxOIAuUq KcpsSAtRl0QPXkbePDiYXpA31J4apLHk9mGPw5dN8KKq/u6nfwvpeWACryfRkKQx PNWiWwz+KQw8fxKO/tkyS6pS3rxgEddL/o6dPAKyaKrp8gatlW/J3M0F/aD2IKg3 /vacoyEbglHCs3oClzb28bUEEUpX0lD3rKbDxdG62iATElJTOyN9r95sTbHzv0Py aVUbu0YMCmihnv/c53FidWy2livNKSsauO+iF9B3OlLvczn2HXT22Bb/IXUaNwZu dtoNegl/ACgZs7ebxjP/9g034ScHdeSU0pkh7x3yQNzjJsJ5kjSeEp5yZ8V1i1E= =FGLk -----END PGP SIGNATURE----- --pL6bkJP1sqToQaub1XnEmF2LFsxdjcwaJ--