From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Peter Chubb <peter.chubb@nicta.com.au>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.
Date: Tue, 20 Aug 2013 16:01:50 +0200 [thread overview]
Message-ID: <521376CE.4090707@suse.de> (raw)
In-Reply-To: <CAFEAcA8dqjCBwUOZcasXsoJJj-Z=NdASBe=MFFKd_JZxABEmyQ@mail.gmail.com>
Am 20.08.2013 15:46, schrieb Peter Maydell:
> On 5 August 2013 02:27, Peter Chubb <peter.chubb@nicta.com.au> wrote:
>>
>> When imx_epit.c was last refactored, a common usecase (comparison
>> register zero) broke. This patch fixes that, and simplifies the code
>> yet more. It also fixes a major thinko in the reset path --- the
>> wrong bits in the control register were being cleared.
>>
>> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
>> Reviewed-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>
>
> Thanks; applied to target-arm.next.
Peter Ch., please call such a patch "imx_epit: " rather than "ARM: "
since it affects only your device. (PMM, can you fix?)
Also if there is a reset bug, then fixing that in its own patch would
better allow backporting that to 1.6.1. The way it is right now with no
Cc: line for qemu-stable, the released version will keep the thinko.
Changing debug output from stdout to stderr would've also been a change
of its own that is not even mentioned in the commit message.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-20 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 1:27 [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation Peter Chubb
2013-08-20 13:46 ` Peter Maydell
2013-08-20 14:01 ` Andreas Färber [this message]
2013-08-20 14:05 ` Peter Maydell
2013-08-21 0:54 ` peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521376CE.4090707@suse.de \
--to=afaerber@suse.de \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).