From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBmVV-0002av-0j
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:02:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBmVP-0002JK-Ba
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:02:00 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55614 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBmVP-0002Ix-5E
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:01:55 -0400
Message-ID: <521376CE.4090707@suse.de>
Date: Tue, 20 Aug 2013 16:01:50 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <84ppttj5ak.wl%peter.chubb@nicta.com.au>
	<CAFEAcA8dqjCBwUOZcasXsoJJj-Z=NdASBe=MFFKd_JZxABEmyQ@mail.gmail.com>
In-Reply-To: <CAFEAcA8dqjCBwUOZcasXsoJJj-Z=NdASBe=MFFKd_JZxABEmyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit
	implementation.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Peter Chubb <peter.chubb@nicta.com.au>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 20.08.2013 15:46, schrieb Peter Maydell:
> On 5 August 2013 02:27, Peter Chubb <peter.chubb@nicta.com.au> wrote:
>>
>> When imx_epit.c was last refactored, a common usecase (comparison
>> register zero) broke.  This patch fixes that, and simplifies the code
>> yet more.  It also fixes a major thinko in the reset path --- the
>> wrong bits in the control register were being cleared.
>>
>> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
>> Reviewed-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>
>=20
> Thanks; applied to target-arm.next.

Peter Ch., please call such a patch "imx_epit: " rather than "ARM: "
since it affects only your device. (PMM, can you fix?)

Also if there is a reset bug, then fixing that in its own patch would
better allow backporting that to 1.6.1. The way it is right now with no
Cc: line for qemu-stable, the released version will keep the thinko.
Changing debug output from stdout to stderr would've also been a change
of its own that is not even mentioned in the commit message.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg