From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBmXa-0004U6-0S for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBmXU-0003SX-1c for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:04:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBmXT-0003SP-Qj for qemu-devel@nongnu.org; Tue, 20 Aug 2013 10:04:03 -0400 Message-ID: <52137724.1080609@redhat.com> Date: Tue, 20 Aug 2013 16:03:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377006143-15753-1-git-send-email-charlie@ctshepherd.com> <521372F7.2090508@redhat.com> <5213741E.3040702@ctshepherd.com> In-Reply-To: <5213741E.3040702@ctshepherd.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, stefanha@gmail.com, gabriel@kerneis.info, qemu-devel@nongnu.org Il 20/08/2013 15:50, Charlie Shepherd ha scritto: > On 20/08/2013 14:45, Paolo Bonzini wrote: >> I had very similar patches in my series to add get_block_status... > > Ah, sorry if I've duplicated something you've already done. Stefan > encouraged me to contribute to an area of QEMU I found interesting and > seeing the XXX I thought I'd take a shot at improving the code. Where > should I look in the future for patches like this? There is still room for improvement in this area. You can compare my patches and yours, they follow very different ideas. I could pick up your patch in my series too, actually, if they're reviewed fast enough (I'm not sure I'll have the cycles to do that, unfortunately). Paolo