From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5rN-0004q2-M3 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:41:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC5rH-0003iH-Fx for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:41:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5rG-0003hh-Qc for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:41:47 -0400 Message-ID: <52149937.4040700@redhat.com> Date: Wed, 21 Aug 2013 12:40:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-7-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1377069536-12658-7-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com Il 21/08/2013 09:18, Lei Li ha scritto: > It should set negative error value if there has been an error. > > Signed-off-by: Lei Li > --- > savevm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 1522d95..f10e031 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) > > void ram_control_load_hook(QEMUFile *f, uint64_t flags) > { > - int ret = 0; > + int ret = -1; -EINVAL otherwise looks good thanks! Paolo > if (f->ops->hook_ram_load) { > ret = f->ops->hook_ram_load(f, f->opaque, flags); >