From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5th-0000Qi-2z for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC5tU-0004nA-G7 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:44:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5tU-0004n0-8e for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:44:04 -0400 Message-ID: <521499B5.3010604@redhat.com> Date: Wed, 21 Aug 2013 12:43:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-6-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1377069536-12658-6-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/18] savevm: add comments for qemu_file_get_error() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com Il 21/08/2013 09:18, Lei Li ha scritto: > Add comments for qemu_file_get_error(), as its return value > is not very clear. > > Signed-off-by: Lei Li > --- > savevm.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 6362275..1522d95 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -566,6 +566,13 @@ QEMUFile *qemu_fopen_ops(void *opaque, const QEMUFileOps *ops) > return f; > } > > +/* > + * Get last error for stream f > + * > + * Return negtive error value if there has been an error on previous > + * operations, return 0 no error happened. > + * > + */ > int qemu_file_get_error(QEMUFile *f) > { > return f->last_error; > Looks good, Paolo