From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5uS-0001o9-9Z for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:45:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC5uM-00050n-9c for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:45:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5uM-00050O-1Q for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:44:58 -0400 Message-ID: <521499F1.1010005@redhat.com> Date: Wed, 21 Aug 2013 12:44:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-11-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1377069536-12658-11-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com Il 21/08/2013 09:18, Lei Li ha scritto: > Implementation of outgoing part for localhost migration. > The integration of migration thread and corresponding > adjustment will be in coming patches. > > Signed-off-by: Lei Li > --- > include/migration/migration.h | 2 + > migration-local.c | 85 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index 5336117..d2c7eff 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -92,6 +92,8 @@ void rdma_start_outgoing_migration(void *opaque, const char *host_port, Error ** > > void rdma_start_incoming_migration(const char *host_port, Error **errp); > > +void local_start_outgoing_migration(void *opaque, const char *uri, Error **errp); > + > void migrate_fd_error(MigrationState *s); > > void migrate_fd_connect(MigrationState *s); > diff --git a/migration-local.c b/migration-local.c > index 93190fd..cf4a091 100644 > --- a/migration-local.c > +++ b/migration-local.c > @@ -209,3 +209,88 @@ static void *qemu_fopen_local(int fd, const char *mode) > > return s->file; > } > + > +/************************************************************************ > + * Outgoing part > + **/ > + > +static QEMUFileLocal *local_migration_init(void) > +{ > + QEMUFileLocal *s = g_malloc0(sizeof(*s)); > + > + s->state = MIG_STATE_SETUP; > + trace_migrate_set_state(MIG_STATE_SETUP); > + s->fd = -1; > + s->last_block_sent = NULL; > + > + return s; > +} It's not clear why this is needed, it looks like a violation of encapsulation. Paolo