From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC614-0000SY-JF
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:52:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC60y-0007pi-B7
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:51:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VC60y-0007pP-35
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:51:48 -0400
Message-ID: <52149B8F.3060408@redhat.com>
Date: Wed, 21 Aug 2013 12:50:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com>
	<1377069536-12658-15-git-send-email-lilei@linux.vnet.ibm.com>
In-Reply-To: <1377069536-12658-15-git-send-email-lilei@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/18] arch_init: skip
 migration_bitmap_sync for local migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com

Il 21/08/2013 09:18, Lei Li ha scritto:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  arch_init.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index cbbb4db..e6069eb 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -375,6 +375,11 @@ static void migration_bitmap_sync(void)
>      int64_t end_time;
>      int64_t bytes_xfer_now;
>  
> +    /* No need to sync with bitmap for local migration */
> +    if (migrate_is_localhost()) {
> +        return;
> +    }
> +
>      if (!bytes_xfer_prev) {
>          bytes_xfer_prev = ram_bytes_transferred();
>      }
> 

Premature, please do this after everything is in place (including
vmsplice) and only if you find the dirty bitmap to be a significant
source of overhead.

Paolo