From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC6a0-0002PW-KP for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:28:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC6Zs-00041c-7N for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:28:00 -0400 Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:62522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC6Zs-00041X-3a for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:27:52 -0400 Received: by mail-qc0-f178.google.com with SMTP id s1so129121qcw.23 for ; Wed, 21 Aug 2013 04:27:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5214A40A.4030409@redhat.com> Date: Wed, 21 Aug 2013 13:27:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <0577863ea4bc4e0d91675e4fd250c1065ba4ebd9.1377075625.git.hutao@cn.fujitsu.com> <1377082892.31946.7.camel@nilsson.home.kraxel.org> In-Reply-To: <1377082892.31946.7.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Hu Tao , qemu-devel@nongnu.org Il 21/08/2013 13:01, Gerd Hoffmann ha scritto: > Hi, > >> +#define ICH9_PROC_BASE 0xaf00 >> +#define ICH9_PROC_LEN 32 > > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff > I/O port window to a PCI bridge. Please lets stop occupy random io > ports above 0x1000 and burn I/O address space that way. > > I'd suggest to place it at 0x0a00 instead. Also the dsdt should get a > device with the address in _CRS so the guest knows those ports are used. Would this use 0x0A ("not present, device functional, decoding resources") for _STA to "indicate a valid device for which no device driver should be loaded" (quoting from the ACPI spec)? Hopefully this prevents Windows from showing the UI. Paolo