Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On 08/21/2013 01:18 AM, Lei Li wrote:
> Introduce migration capability localhost.
> 
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  include/migration/migration.h |    3 +++
>  migration.c                   |   12 ++++++++++++
>  qapi-schema.json              |    8 +++++++-
>  3 files changed, 22 insertions(+), 1 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -629,10 +629,16 @@
>  # @auto-converge: If enabled, QEMU will automatically throttle down the guest
>  #          to speed up convergence of RAM migration. (since 1.6)
>  #
> +# @localhost: If enabled, QEMU will support localhost migration. This feature
> +#             allows live upgrade of a running QEMU instance by doing localhost
> +#             migration with page flipping. It requires the source and destination
> +#             are both on localhost. Disabled by default. (since 1.7)

Logically, ALL new migration parameters should be disabled by default,
as that provides the sanest back-compat setting.  Your last sentence is
therefore redundant.  But this is certainly a much nicer implementation
than your v1 attempt.

If I understand correctly, attempts to use 'local:...' are rejected
unless you first use migrate-set-capabilities to turn on localhost
migration support.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]