From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCA6e-0005F5-4F for qemu-devel@nongnu.org; Wed, 21 Aug 2013 11:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCA6Z-0000LW-88 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 11:13:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCA6Y-0000LH-VG for qemu-devel@nongnu.org; Wed, 21 Aug 2013 11:13:51 -0400 Message-ID: <5214D92B.1030706@redhat.com> Date: Wed, 21 Aug 2013 09:13:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377090999-18217-1-git-send-email-stefanha@redhat.com> <1377090999-18217-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1377090999-18217-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UKUoLNslT2sbmpLUBdrWIpiaKPH3kNmn2" Subject: Re: [Qemu-devel] [PATCH v2 2/2] osdep: warn if opening a file O_DIRECT on tmpfs fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Deepak C Shetty , qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UKUoLNslT2sbmpLUBdrWIpiaKPH3kNmn2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/21/2013 07:16 AM, Stefan Hajnoczi wrote: > Print a warning when opening a file O_DIRECT on tmpfs fails. This save= s > users a lot of time trying to figure out the EINVAL error. >=20 > Daniel P. Berrange suggested opening the file > without O_DIRECT as a portable way to check whether the file system > supports O_DIRECT. That gets messy when flags contains O_CREAT since > we'd create a file but return an error - or a race condition if we try > to unlink the file. It's simpler to check the file system type. >=20 > Reported-by: Deepak C Shetty > Signed-off-by: Stefan Hajnoczi > --- > util/osdep.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UKUoLNslT2sbmpLUBdrWIpiaKPH3kNmn2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSFNkrAAoJEKeha0olJ0Nq6w8IAISh3ERqfdc4NXDFZZLOUEkr u+zWVhNNgW1i9DT+iF4vuKZjk7/c8Z4K6hfom7VDs7ohxkuarGjVzUL+s9vB6tHZ L7YjXFO/aoBDxVg6o9un0F1WYlDjUqMEtt47xIAvNxBLouLEQk48i1CXbiJYSK7b +7GUBt0O0oTedb4fzB8inzJxiGioVe2SmxjPr8yRMXTAT4IFgkHkIasOKLRtGScf tDoaeU1+6A+5qWVnMxDcW8/s+FE8MXY9hHe1ATiO1cDxNRIkTqPUI+G0Kx03ggZp qEu7cAw6kWOTfWij1te0Obb9ShBv/dlAClA0R+RHX3HAY2qg+QbUX45v9qc4tm0= =QhyA -----END PGP SIGNATURE----- --UKUoLNslT2sbmpLUBdrWIpiaKPH3kNmn2--