From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com,
lersek@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com,
anthony@codemonkey.ws, hutao@cn.fujitsu.com,
lcapitulino@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Start fixing the pvpanic mess
Date: Wed, 21 Aug 2013 18:51:11 +0200 [thread overview]
Message-ID: <5214EFFF.3060804@redhat.com> (raw)
In-Reply-To: <20130821164817.GC10012@redhat.com>
Il 21/08/2013 18:48, Daniel P. Berrange ha scritto:
> No, <on_crash> is the right thing to be using for this from
> libvirt's pov & I don't think we should invent something new.
> The <on_crash> element has always been intended to represent
> handling of guest panics, not qemu internal errors.
Actually for Xen HVM guests, it mostly traps things such as failed
vmentries. The Xen PV-on-HVM drivers do not register a panic notifier
that moves the guest to the "crashed" state.
<on_crash> cannot be salvaged, in my opinion, because all domain XMLs in
the wild will have a setting that causes libvirt to add "-device
isa-pvpanic". Thus changing libvirt versions will change guest
hardware, which is _very_ bad.
In addition, Windows XP and 2003 will show the annoying device wizard
upon a libvirt upgrade, and fixing this is what surfaced all the mess.
Paolo
next prev parent reply other threads:[~2013-08-21 16:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:43 [Qemu-devel] [RFC PATCH v2 0/3] Start fixing the pvpanic mess Paolo Bonzini
2013-08-21 16:43 ` [Qemu-devel] [PATCH 1/3] vl: allow "cont" from panicked state Paolo Bonzini
2013-08-21 16:43 ` [Qemu-devel] [PATCH 2/3] pc: get rid of builtin pvpanic Paolo Bonzini
2013-08-21 17:03 ` Michael S. Tsirkin
2013-08-21 17:02 ` Paolo Bonzini
2013-08-21 17:07 ` Andreas Färber
2013-08-21 17:04 ` Michael S. Tsirkin
2013-08-21 17:33 ` Michael S. Tsirkin
2013-08-21 16:43 ` [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic Paolo Bonzini
2013-08-21 17:01 ` Michael S. Tsirkin
2013-08-21 17:01 ` Paolo Bonzini
2013-08-21 17:07 ` Michael S. Tsirkin
2013-08-21 17:06 ` Paolo Bonzini
2013-08-21 17:31 ` Michael S. Tsirkin
2013-08-22 12:43 ` Laszlo Ersek
2013-08-22 12:41 ` Paolo Bonzini
2013-08-25 10:44 ` Michael S. Tsirkin
2013-08-22 16:50 ` Anthony Liguori
2013-08-25 10:29 ` Michael S. Tsirkin
2013-08-21 17:35 ` Andreas Färber
2013-08-21 17:46 ` Paolo Bonzini
2013-08-21 16:48 ` [Qemu-devel] [RFC PATCH v2 0/3] Start fixing the pvpanic mess Daniel P. Berrange
2013-08-21 16:51 ` Paolo Bonzini [this message]
2013-08-21 16:55 ` Daniel P. Berrange
2013-08-21 16:56 ` Paolo Bonzini
2013-08-21 17:10 ` Eric Blake
2013-08-21 17:11 ` Paolo Bonzini
2013-08-22 9:17 ` Daniel P. Berrange
2013-08-21 17:02 ` Eric Blake
2013-08-21 17:10 ` Paolo Bonzini
2013-08-21 17:26 ` Michael S. Tsirkin
2013-08-21 17:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214EFFF.3060804@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).