From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBz6-0007GP-17 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:14:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCBz0-0007me-2O for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:14:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCBjA-0000ym-5w for qemu-devel@nongnu.org; Wed, 21 Aug 2013 12:57:48 -0400 Message-ID: <5214F154.4030101@redhat.com> Date: Wed, 21 Aug 2013 18:56:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> <20130821164817.GC10012@redhat.com> <5214EFFF.3060804@redhat.com> <20130821165529.GE10012@redhat.com> In-Reply-To: <20130821165529.GE10012@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Start fixing the pvpanic mess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com, afaerber@suse.de Il 21/08/2013 18:55, Daniel P. Berrange ha scritto: > On Wed, Aug 21, 2013 at 06:51:11PM +0200, Paolo Bonzini wrote: >> Il 21/08/2013 18:48, Daniel P. Berrange ha scritto: >>> No, is the right thing to be using for this from >>> libvirt's pov & I don't think we should invent something new. >>> The element has always been intended to represent >>> handling of guest panics, not qemu internal errors. >> >> Actually for Xen HVM guests, it mostly traps things such as failed >> vmentries. The Xen PV-on-HVM drivers do not register a panic notifier >> that moves the guest to the "crashed" state. >> >> cannot be salvaged, in my opinion, because all domain XMLs in >> the wild will have a setting that causes libvirt to add "-device >> isa-pvpanic". Thus changing libvirt versions will change guest >> hardware, which is _very_ bad. >> >> In addition, Windows XP and 2003 will show the annoying device wizard >> upon a libvirt upgrade, and fixing this is what surfaced all the mess. > > The existance of a element should not be having any > effect on what hardware we create. That is merely a lifecycle > policy setting that should be completely independant of the > guest device model. > > eg it is valid to have present in the XML at all > times, even if there's no pvpanic device present. That simply > means the actions will never be triggered. So are you suggesting to add a element to ? That may be fine, but it doesn't seem very user-friendly. Paolo