From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCBov-000547-Lp
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:03:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCBoo-0003Qe-1X
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:03:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCBon-0003QR-QI
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:03:37 -0400
Message-ID: <5214F2B5.2080507@redhat.com>
Date: Wed, 21 Aug 2013 19:02:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com>
	<1377103396-24307-3-git-send-email-pbonzini@redhat.com>
	<20130821170358.GB12305@redhat.com>
In-Reply-To: <20130821170358.GB12305@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] pc: get rid of builtin pvpanic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com, afaerber@suse.de

Il 21/08/2013 19:03, Michael S. Tsirkin ha scritto:
>> > It is a source of pain, and the previous patch anyway changed the
>> > behavior of "-M pc-1.5" compared to the real 1.5.
>> > 
>> > This also makes it clear that "-device pvpanic" is not enough:
>> > it will not expose pvpanic in fw_cfg properly.
>> > 
>> > No idea how to fix that.
>> > 
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> That should be the first step. Make the device work properly.
> We'll discuss compatibility when that is clear.
> 

Actually these patches are not based on origin/master (my mistake)... I
haven't tested, rebasing should be enough if "-device pvpanic" was
tested properly for 1.6.

Paolo