From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCCUz-0003m7-Cf for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:47:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCCUq-0004m5-PS for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:47:13 -0400 Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:43660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCCUq-0004lr-IR for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:47:04 -0400 Received: by mail-ee0-f53.google.com with SMTP id b15so425510eek.26 for ; Wed, 21 Aug 2013 10:47:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5214FCEB.5090805@redhat.com> Date: Wed, 21 Aug 2013 19:46:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> <1377103396-24307-4-git-send-email-pbonzini@redhat.com> <20130821170120.GA12305@redhat.com> <5214FA56.3030509@suse.de> In-Reply-To: <5214FA56.3030509@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, hutao@cn.fujitsu.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, lcapitulino@redhat.com, lersek@redhat.com Il 21/08/2013 19:35, Andreas Färber ha scritto: > Am 21.08.2013 19:01, schrieb Michael S. Tsirkin: >> On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: >>> The pvpanic situation is already messed up enough. Let us give our >>> libvirt friends an easy indication that we have untied our side. >>> >>> Not-yet-signed-off-by: Paolo Bonzini >>> ... because we first have to determine how to expose the device's existence >>> in the ACPI tables or in fw_cfg. >>> >>> Signed-off-by: Paolo Bonzini >> >> So it's isa-pvpanic meaning "I-am-sure-this-is-the-last-bug-pvpanic" >> >> If we feel there's need to give libvirt a way to do >> introspection into QEMU bugs, let's architect one. >> Randomly renaming devices in the vain hope it's >> the last major bug is not it. >> >> NACK > > Seconded. While we shouldn't rule out renaming devices, doing so as a > criteria for libvirt sounds utterly wrong. > > Paolo, you are right that a single "NACK" cannot be a criteria, but a > single convincing justification by a random reviewer should be > sufficient to reconsider. :) > > Adding some device property or obtaining the info via some existing > query-* QMP command might be better alternatives. Device properties are a good way to communicate changes to the guest, but here the guest ABI is unchanged. Anyhow, this patch is not strictly necessary. It's just a safety net to avoid that libvirt uses a buggy device on buggy versions of QEMU. Paolo