From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCDMi-0004lg-3S for qemu-devel@nongnu.org; Wed, 21 Aug 2013 14:42:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCDMd-00010S-70 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 14:42:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCDMc-00010I-TQ for qemu-devel@nongnu.org; Wed, 21 Aug 2013 14:42:39 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7LIgcJM011196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Aug 2013 14:42:38 -0400 Message-ID: <52150A1D.5040701@redhat.com> Date: Wed, 21 Aug 2013 12:42:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1375071932-31627-1-git-send-email-famz@redhat.com> <1375071932-31627-4-git-send-email-famz@redhat.com> In-Reply-To: <1375071932-31627-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UGA4RwpnjDbvfLxv3qewaCLuG16E82gPF" Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qmp: Add "snapshot=" option to nbd-server-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, pbonzini@redhat.com, imain@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UGA4RwpnjDbvfLxv3qewaCLuG16E82gPF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/28/2013 10:25 PM, Fam Zheng wrote: > With drive-backup block job, we can have a point-in-time snapshot of a > device. With snapshot=3Don, a backup block job is started on the device= to > do CoW to a temporary image and this image is exported to nbd. The imag= e > is deleted after nbd server stops. >=20 > Signed-off-by: Fam Zheng > --- > blockdev-nbd.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++-- > hmp.c | 5 ++-- > qapi-schema.json | 3 ++- > qmp-commands.hx | 2 +- > 4 files changed, 80 insertions(+), 6 deletions(-) In addition to Stefan's comments about missing docs... > +++ b/qapi-schema.json > @@ -3225,7 +3225,8 @@ > # > # Since: 1.3.0 > ## > -{ 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable': = 'bool'} } > +{ 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable': = 'bool', > + '*snapshot': 'bool'} } When documenting the new option, be sure to use a (since 1.7) tag. Also, it would be nice to get introspection in (otherwise, libvirt cannot learn whether '*snapshot' is supported without trying and failing on older qemu). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UGA4RwpnjDbvfLxv3qewaCLuG16E82gPF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSFQodAAoJEKeha0olJ0NqTM4H/iLe5kqlfYxVssLRtFww+IAl bAFDA5NKQH5BaFZCEfDvHE2t+H5W025p07uZFEAHjG1UmCZwzjvaaW/rHHc7KK8N 2pYeVFk1/pP2SEoWG3GiHUyfBirhENAwt8EJhNFDrv5vcwpt3xCUySGlFFEqFtk+ 8EefSwv2YnAm5BqH30uXL/p6fo//wQ3ErxPGN8ToWW510YmzqedBzik8YrvHbFKf 1KsVMagPA0GCvd+BoUOGcx/uXtkUHD+rBRYWpXUyimMIE9HW1q1qGN/88yJdz7tM E2VbRFKP/O6QCmC+QAv+OA1c8aU3Y5XOdoPBLmBZ0+QqerEh8HAE6/nn57+IF1o= =HzMX -----END PGP SIGNATURE----- --UGA4RwpnjDbvfLxv3qewaCLuG16E82gPF--