From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCFVN-00076a-Qh for qemu-devel@nongnu.org; Wed, 21 Aug 2013 16:59:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCFVJ-0000mx-In for qemu-devel@nongnu.org; Wed, 21 Aug 2013 16:59:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCFVJ-0000mk-B5 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 16:59:45 -0400 Message-ID: <52152A36.80705@redhat.com> Date: Wed, 21 Aug 2013 14:59:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376960839-13033-1-git-send-email-gaowanlong@cn.fujitsu.com> <1376960839-13033-2-git-send-email-gaowanlong@cn.fujitsu.com> In-Reply-To: <1376960839-13033-2-git-send-email-gaowanlong@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x7dh9MqNOu2Vv7pIj7m9HXrOC9Rn1aw7D" Subject: Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wanlong Gao Cc: aliguori@us.ibm.com, ehabkost@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, lersek@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x7dh9MqNOu2Vv7pIj7m9HXrOC9Rn1aw7D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/19/2013 07:07 PM, Wanlong Gao wrote: > Reviewed-by: Laszlo Ersek > Signed-off-by: Wanlong Gao > --- > qapi-schema.json | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) >=20 > +## > +# @NumaNodeOptions > +# > +# Create a guest NUMA node. > +# > +# @nodeid: #optional NUMA node ID > +# > +# @cpus: #optional VCPUs belong to this node > +# > +# @mem: #optional memory size of this node (remain as legacy) What does (remain as legacy) mean, that I shouldn't use this parameter? Is it something where the command line parsing code should be translating the legacy option into the correct usage of the QMP command, so we don't have to expose cruft? > +# > +# Since: 1.7 > +## > +{ 'type': 'NumaNodeOptions', > + 'data': { > + '*nodeid': 'uint16', > + '*cpus': ['uint16'], > + '*mem': 'str' }} Why is size passed as a 'str' instead of an integral type? If anything, at the QMP layer, it should be an integer representing size in bytes (the command line and HMP are already capable of converting shorthand like 1G into proper byte counts for use in QAPI). > + > +## > +# @NumaMemOptions > +# > +# Set memory information of guest NUMA node. > +# > +# @nodeid: #optional NUMA node ID > +# > +# @size: #optional memory size of this node If everything is optional, then what defaults are used if I specify nothing? Should nodeid be mandatory (here, and in NumaNodeOptions)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x7dh9MqNOu2Vv7pIj7m9HXrOC9Rn1aw7D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSFSo2AAoJEKeha0olJ0Nqd/oIAJp42DDZWOrmTdsTXXbHb0Ks 5u6BGx6oTLqqBPVCmrJ7YVSFfHNl6zX8Iguh3opSAUGeih8nA8V3PV/1s8rTOBme gtRFKzbXu55sbZS3qVQdP+wfvi1O8qB9gA3xshJwI1VXV4Bdc+zM0EA73FRWBSTY olj3237jT2oNH9LURXBmW4lQHMPg9yO92qH5D23N6LcAKn+xMPMepKKRW49nGwU0 0T18RRQGWoQX6sqaXhuBdslIwyQqXO6aBi7QSVI0hrI1Qwbi80ZhFERqZbVJEZz2 oqyXRlcdWZ28zhfx95bLgmvyJc3ub+RMxFJtyYQIiLMjqdcgN0px8I/QRrEyuaU= =Ckb/ -----END PGP SIGNATURE----- --x7dh9MqNOu2Vv7pIj7m9HXrOC9Rn1aw7D--