Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

On 08/21/2013 07:12 PM, Wanlong Gao wrote:

>>> +   '*mem':    'str' }}
>>
>> Why is size passed as a 'str' instead of an integral type?  If anything,
>> at the QMP layer, it should be an integer representing size in bytes
>> (the command line and HMP are already capable of converting shorthand
>> like 1G into proper byte counts for use in QAPI).
> 
> Since the original "mem" options is MB default, but "size" type is byte default,
> so we should pass a "str" first to be consistent with original option.

No. HMP is human-friendly - it can default to M.  QMP is
machine-friendly - it should default to bytes and take an 'int' rather
than a 'str'.  Part of the glue between HMP and QMP is converting from
human-friendly to machine-friendly, so that QMP doesn't have to carry cruft.


>>> +#
>>> +# @nodeid: #optional NUMA node ID
>>> +#
>>> +# @size: #optional memory size of this node
>>
>> If everything is optional, then what defaults are used if I specify
>> nothing?  Should nodeid be mandatory (here, and in NumaNodeOptions)?
> 
> The defaults are all consistent with original behaviour. If nodeid is
> omitted, the option will be assigned node by node from node0.

What will be assigned?  If I omit both nodeid and size, there's nothing
left in the object I'm passing.  Just because HMP can do sane defaults
doesn't mean that QMP needs to mark all fields as optional.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]