From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] int128: add int128_exts64()
Date: Thu, 22 Aug 2013 13:14:51 +0200 [thread overview]
Message-ID: <5215F2AB.3030509@redhat.com> (raw)
In-Reply-To: <5215ECFB.6080908@ozlabs.ru>
Il 22/08/2013 12:50, Alexey Kardashevskiy ha scritto:
> 1) return (Int128) { .lo = a, .hi = (a < 0) ? -1 : 0 };
> 2) return (Int128) { .lo = a, .hi = (a < 0) };
> 3) return (Int128) { .lo = a, .hi = a >> 63 };
>
> So with which one should I repost the patch?
The second would be "-(a < 0)" actually. Peter wants (1) I think, so go
for it.
Paolo
next prev parent reply other threads:[~2013-08-22 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 8:20 [Qemu-devel] [PATCH v2 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-22 8:20 ` [Qemu-devel] [PATCH v2 1/3] int128: add int128_exts64() Alexey Kardashevskiy
2013-08-22 9:09 ` Paolo Bonzini
2013-08-22 9:47 ` Peter Maydell
2013-08-22 9:48 ` Paolo Bonzini
2013-08-22 10:43 ` Peter Maydell
2013-08-22 10:50 ` Alexey Kardashevskiy
2013-08-22 11:14 ` Paolo Bonzini [this message]
2013-08-22 8:20 ` [Qemu-devel] [PATCH v2 2/3] vfio: Fix debug output for int128 values Alexey Kardashevskiy
2013-08-22 8:20 ` [Qemu-devel] [PATCH v2 3/3] vfio: Fix 128 bit handling Alexey Kardashevskiy
2013-08-22 9:11 ` Paolo Bonzini
2013-08-22 10:41 ` Alexey Kardashevskiy
2013-08-22 11:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215F2AB.3030509@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).