From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCSrd-0002eO-6j
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 07:15:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCSrW-0005lu-VY
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 07:15:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VCSrW-0005li-Je
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 07:15:34 -0400
Message-ID: <5215F2AB.3030509@redhat.com>
Date: Thu, 22 Aug 2013 13:14:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377159632-7446-1-git-send-email-aik@ozlabs.ru>
	<1377159632-7446-2-git-send-email-aik@ozlabs.ru>
	<5215D561.3050702@redhat.com>
	<CAFEAcA_WDhmGLpzo=+sodS+ZwTW-Kb-U9jw4SP3Sjz0P3Ds+1w@mail.gmail.com>
	<5215DE80.4030203@redhat.com> <5215ECFB.6080908@ozlabs.ru>
In-Reply-To: <5215ECFB.6080908@ozlabs.ru>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] int128: add int128_exts64()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>, Alex Williamson <alex.williamson@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Il 22/08/2013 12:50, Alexey Kardashevskiy ha scritto:
> 1) return (Int128) { .lo = a, .hi = (a < 0) ? -1 : 0 };
> 2) return (Int128) { .lo = a, .hi = (a < 0) };
> 3) return (Int128) { .lo = a, .hi = a >> 63 };
> 
> So with which one should I repost the patch?

The second would be "-(a < 0)" actually.  Peter wants (1) I think, so go
for it.

Paolo