[Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

[Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

[Marcel Apfelbaum]

Thanks to Markus Armbruster <armbru@redhat.com>
for finding this bug.

Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
 hw/usb/dev-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index 66c6331..5956720 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
     uc->product_desc   = "QEMU USB Tablet";
     dc->vmsd = &vmstate_usb_ptr;
     dc->props = usb_tablet_properties;
-    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
 }
 
 static const TypeInfo usb_tablet_info = {
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

[Andreas Färber]

Am 22.08.2013 14:14, schrieb Marcel Apfelbaum:
> Thanks to Markus Armbruster <armbru@redhat.com>
> for finding this bug.

The simplest way to record that is:
Reported-by: Markus Armbruster <armbru@redhat.com>

And since this doesn't affect all of hw/, something like "usb/dev-hid:"
might been better; but Gerd as USB maintainer (CC'ed) would be the one
most qualified to change or to instruct to his likings.

Probably missing
Cc: qemu-stable@nongnu.org
to have it fixed in 1.6.1?

> 
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>

Change itself looks fine,

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

[Michael Roth]

Quoting Andreas Färber (2013-08-22 08:16:38)
> Am 22.08.2013 14:14, schrieb Marcel Apfelbaum:
> > Thanks to Markus Armbruster <armbru@redhat.com>
> > for finding this bug.
> 
> The simplest way to record that is:
> Reported-by: Markus Armbruster <armbru@redhat.com>
> 
> And since this doesn't affect all of hw/, something like "usb/dev-hid:"
> might been better; but Gerd as USB maintainer (CC'ed) would be the one
> most qualified to change or to instruct to his likings.
> 
> Probably missing
> Cc: qemu-stable@nongnu.org
> to have it fixed in 1.6.1?
> 
> > 
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> 
> Change itself looks fine,
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Ping for stable 1.6.1

> 
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

[Michael Roth]

Quoting Michael Roth (2013-09-24 19:04:28)
> Quoting Andreas Färber (2013-08-22 08:16:38)
> > Am 22.08.2013 14:14, schrieb Marcel Apfelbaum:
> > > Thanks to Markus Armbruster <armbru@redhat.com>
> > > for finding this bug.
> > 
> > The simplest way to record that is:
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > 
> > And since this doesn't affect all of hw/, something like "usb/dev-hid:"
> > might been better; but Gerd as USB maintainer (CC'ed) would be the one
> > most qualified to change or to instruct to his likings.
> > 
> > Probably missing
> > Cc: qemu-stable@nongnu.org
> > to have it fixed in 1.6.1?
> > 
> > > 
> > > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> > 
> > Change itself looks fine,
> > 
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Ping for stable 1.6.1

Bah! Once again, disregard, looks like this was merged under a different name.

Sorry for the noise.

> 
> > 
> > Andreas
> > 
> > -- 
> > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg