From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, "Marcel Apfelbaum" <marcel.a@redhat.com>,
mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines
Date: Thu, 22 Aug 2013 09:34:05 -0600 [thread overview]
Message-ID: <52162F6D.7070605@redhat.com> (raw)
In-Reply-To: <878uztstin.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On 08/22/2013 08:13 AM, Markus Armbruster wrote:
>>> +++ b/qdev-monitor.c
>>> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory category)
>>> DeviceClass *dc;
>>> GSList *list, *curr;
>>>
>>> + error_printf("%s devices:\n", qdev_category_get_name(category));
>>
>> Why is that an error? Shouldn't it go to stdout?
>
> Output of -device help has always gone to stderr, and that has always
> annoyed me. Just not enough to fix it.
Back when libvirt scraped -help output, changing it to use stdout would
be an incompatible change. But now that libvirt uses QMP, I would also
welcome a change to use stdout (but also fall in the category of "not
enough of a bother for ME to fix it).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-22 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:48 [Qemu-devel] [PATCH ] qemu-help: add category headlines Marcel Apfelbaum
2013-08-22 14:00 ` Andreas Färber
2013-08-22 14:13 ` Markus Armbruster
2013-08-22 15:34 ` Eric Blake [this message]
2013-08-22 17:18 ` Marcel Apfelbaum
2013-08-22 17:47 ` Markus Armbruster
2013-08-28 8:10 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52162F6D.7070605@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).