From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCWtq-00056E-En for qemu-devel@nongnu.org; Thu, 22 Aug 2013 11:34:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCWtl-00055a-Jc for qemu-devel@nongnu.org; Thu, 22 Aug 2013 11:34:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCWtl-00054Q-Ba for qemu-devel@nongnu.org; Thu, 22 Aug 2013 11:34:09 -0400 Message-ID: <52162F6D.7070605@redhat.com> Date: Thu, 22 Aug 2013 09:34:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> <5216197C.2060509@suse.de> <878uztstin.fsf@blackfin.pond.sub.org> In-Reply-To: <878uztstin.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VJuGaEqAUqShN7F4V0qT6dmr0kxwf32GI" Subject: Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, Marcel Apfelbaum , mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VJuGaEqAUqShN7F4V0qT6dmr0kxwf32GI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/22/2013 08:13 AM, Markus Armbruster wrote: >>> +++ b/qdev-monitor.c >>> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCat= egory category) >>> DeviceClass *dc; >>> GSList *list, *curr; >>> =20 >>> + error_printf("%s devices:\n", qdev_category_get_name(category));= >> >> Why is that an error? Shouldn't it go to stdout? >=20 > Output of -device help has always gone to stderr, and that has always > annoyed me. Just not enough to fix it. Back when libvirt scraped -help output, changing it to use stdout would be an incompatible change. But now that libvirt uses QMP, I would also welcome a change to use stdout (but also fall in the category of "not enough of a bother for ME to fix it). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VJuGaEqAUqShN7F4V0qT6dmr0kxwf32GI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSFi9tAAoJEKeha0olJ0NqymoIAIvfi+GFvbfx9OlJdcMPgF/y 1CCqcF4hica0iZm+UaY344+6X1eIzK7BsQiwu0UA37qMtzHWF4Zrh6mlx6QjTiAI Z5SCa/eXQRwxn7o34RxlK4/xygLcnkaQ9e1472Vl71dhZK6dO3ejR461kaeP2gjP IddnnDtRR7IRssBqCRqQ/2OFGLyjlmlhSBzQLhx/h2gjWxaJy9FvLrBUah8lGpzB VkcSIUt5ECQUOBVp5eqtskEiPRNdcJNCktd+TUR34QLFnggPZvGsP6dTNPS1BfLN UNM8GbrwMor5bgLaC8f8Psfj9mMau8tp6o49YYBt71IDCFS82rMZ00L0mHtdYHg= =7Hki -----END PGP SIGNATURE----- --VJuGaEqAUqShN7F4V0qT6dmr0kxwf32GI--