From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCZ5H-0007ah-G3 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:54:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCZ58-0002Dn-L4 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:54:11 -0400 Received: from mail-ye0-x22e.google.com ([2607:f8b0:4002:c04::22e]:59884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCZ58-0002Df-GS for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:54:02 -0400 Received: by mail-ye0-f174.google.com with SMTP id q1so323979yen.5 for ; Thu, 22 Aug 2013 10:54:01 -0700 (PDT) Sender: Richard Henderson Message-ID: <52165035.3080901@twiddle.net> Date: Thu, 22 Aug 2013 10:53:57 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377190729-14008-1-git-send-email-rth@twiddle.net> <1377190729-14008-2-git-send-email-rth@twiddle.net> <521645BA.5020804@suse.de> In-Reply-To: <521645BA.5020804@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , qemu-devel@nongnu.org, aurelien@aurel32.net On 08/22/2013 10:09 AM, Andreas Färber wrote: > FMT_timeval is a file-local #define, so why not change that instead of > all its users? To what? Unlike size_t, there's no time_t printf format. Recall that checking size(time_t) doesn't suppress the warning when sizeof(int) == sizeof(long)... Since it *is* a local define, it seems easier to match up the users than to do anything else. r~