From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCaSz-0007uB-Vg for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCaSu-0002Ml-Df for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:22:45 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:51807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCaSu-0002Mf-7X for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:22:40 -0400 Received: by mail-wi0-f182.google.com with SMTP id hi8so1104305wib.9 for ; Thu, 22 Aug 2013 12:22:39 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <521664D2.9030900@redhat.com> Date: Thu, 22 Aug 2013 21:21:54 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1376960839-13033-1-git-send-email-gaowanlong@cn.fujitsu.com> <1376960839-13033-2-git-send-email-gaowanlong@cn.fujitsu.com> <52152A36.80705@redhat.com> <52156592.1000905@cn.fujitsu.com> <52157770.7030803@redhat.com> In-Reply-To: <52157770.7030803@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, ehabkost@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, peter.huangpeng@huawei.com, lersek@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 22/08/2013 04:29, Eric Blake ha scritto: >>>>> If everything is optional, then what defaults are used if >>>>> I specify nothing? Should nodeid be mandatory (here, and >>>>> in NumaNodeOptions)? >>> >>> The defaults are all consistent with original behaviour. If >>> nodeid is omitted, the option will be assigned node by node >>> from node0. > What will be assigned? If I omit both nodeid and size, there's > nothing left in the object I'm passing. Just because HMP can do > sane defaults doesn't mean that QMP needs to mark all fields as > optional. Even though this is for the command-line, I agree that both should be mandatory. The default (splitting memory equally across nodes) can be specified by not having "-numa mem" at all, so there is no need to have short versions of the "-numa mem" command line. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSFmTSAAoJEBvWZb6bTYbyzUsP/3BhPGBHfzNsFHdwPL6aiBW4 67TJJ/X9GB4wjav6yjtKtBGuDNOGmEO8BkyJZVNUzw051t74uPpYzDIgd7QvrsU/ nMFRFX6q3vRUxX7k9L5RP3OkJbcAgaq8YQ135XNh59bOEd/VOeTrrEtgqyVPo45h 6tt0JSlGDPF9qc+jGoqgQN8522nvV8mcF/XhJdQ7DqttpAP75ECxViKFKezXwrsh H3dX6v0SbWBMAlihldxEMte8hlKNB/Asb3CDQz5L2ySaPGHcwOI06wSVKGD9slbv 4SSiGg2XMdPx0VKh0ozlKmXE46+hlDJkxi7JLEuscSmZL9gZwFpenz2+29OBk2MM g8fwxKkm36jJE7cnn/z3TPiTVZ7sJm8LvtRW2183CC5I9LpTIUrCZxxP/06ZOREq 2fH41A3PyxDOvhOwp8B3XDAnOkmklSr86hiZR+s3I+59uPa9KzOY2WFeG/6w90uq 6EmZNbmkLrZYfns7wk24YRhH9DAgTFP9GmceaJu0lEbk41INeZggswugwPvrFNI3 bPsXacwK5Y4T4ZkRs4vyaw4Dn2B732D2CMvmPJ+EpKeVIc+8tKMXNtuFKybiraQi zrlHk4zGjeUZwW8+cx8xkHe3qyKUwbYFuRvDqSKXYRrQMzzJNMf/rNGb4JcDHiH6 BmVejHjaYKPJKA+LF3hB =Oqhm -----END PGP SIGNATURE-----