From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VCbqZ-0005Be-GN
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 16:51:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VCbqP-0001xO-JX
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 16:51:11 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:44798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1VCbqP-0001x6-Bx
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 16:51:01 -0400
Received: from /spool/local
	by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Thu, 22 Aug 2013 14:51:00 -0600
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com
	[9.17.195.226])
	by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 089F819D8048
	for <qemu-devel@nongnu.org>; Thu, 22 Aug 2013 14:50:15 -0600 (MDT)
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r7MKoR3Q088742
	for <qemu-devel@nongnu.org>; Thu, 22 Aug 2013 14:50:27 -0600
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id r7MKrHE2016011
	for <qemu-devel@nongnu.org>; Thu, 22 Aug 2013 14:53:18 -0600
Message-ID: <52167992.3080806@linux.vnet.ibm.com>
Date: Thu, 22 Aug 2013 16:50:26 -0400
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com>
	<1377069536-12658-12-git-send-email-lilei@linux.vnet.ibm.com>
	<5214DA32.1060403@redhat.com>
In-Reply-To: <5214DA32.1060403@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability
	localhost
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aarcange@redhat.com, aliguori@us.ibm.com, Lei Li <lilei@linux.vnet.ibm.com>, quintela@redhat.com, qemu-devel@nongnu.org, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com

On 08/21/2013 11:18 AM, Paolo Bonzini wrote:
> Il 21/08/2013 09:18, Lei Li ha scritto:
>>       } else if (strstart(uri, "unix:", &p)) {
>> +        if (s->enabled_capabilities[MIGRATION_CAPABILITY_LOCALHOST]) {
>> +            local_start_outgoing_migration(s, p, &local_err);
>> +        }
>>           unix_start_outgoing_migration(s, p, &local_err);
>>       } else if (strstart(uri, "fd:", &p)) {
>>           fd_start_outgoing_migration(s, p, &local_err);
>> @@ -521,6 +524,15 @@ int migrate_use_xbzrle(void)
>>       return s->enabled_capabilities[MIGRATION_CAPABILITY_XBZRLE];
>>   }
>>   
>> +bool migrate_is_localhost(void)
>> +{
>> +    MigrationState *s;
>> +
>> +    s = migrate_get_current();
>> +
>> +    return s->enabled_capabilities[MIGRATION_CAPABILITY_LOCALHOST];
>> +}
> I think this is a bad name, too.  There is nothing more "local" in this
> migration than in "unix:" migration.
>
> Let's call the capability according to what it does, for example
> unix-page-flipping.
>
> Paolo
>

Why is there a capability at all? Isn't that what the "local" URI is for?

- Michael