From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCgyj-0006Z1-3V for qemu-devel@nongnu.org; Thu, 22 Aug 2013 22:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCgyT-0004rR-1w for qemu-devel@nongnu.org; Thu, 22 Aug 2013 22:19:56 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:46280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCgyS-0004p4-FC for qemu-devel@nongnu.org; Thu, 22 Aug 2013 22:19:40 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 23:13:35 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C9AC63578052 for ; Fri, 23 Aug 2013 12:19:15 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7N23FRl65405156 for ; Fri, 23 Aug 2013 12:03:16 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7N2JEES024013 for ; Fri, 23 Aug 2013 12:19:14 +1000 Message-ID: <5216C641.5020106@linux.vnet.ibm.com> Date: Fri, 23 Aug 2013 10:17:37 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1376042521-12293-1-git-send-email-famz@redhat.com> <20130822113810.GA27613@stefanha-thinkpad.redhat.com> In-Reply-To: <20130822113810.GA27613@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 0/8] Implement reference count for BlockDriverState [resend] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, Fam Zheng , jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com 于 2013-8-22 19:38, Stefan Hajnoczi 写道: > On Fri, Aug 09, 2013 at 06:01:53PM +0800, Fam Zheng wrote: >> [resend to the correct list] >> >> BlockDriverState lifecycle management is needed by future features such as >> image fleecing and blockdev-add. This series adds reference count to >> BlockDriverState. >> >> The first two patches clean up two odd BlockDriverState use cases, so all code >> uses bdrv_new() to create BlockDriverState instance. >> >> Then implemented bdrv_ref() and bdrv_unref() to operate on refcnt: Initially, >> refcnt is 1, which means bdrv_unref is effectively a bdrv_delete() here. So >> patch 04 has a search and replace to convert bdrv_delete to bdrv_unref, before >> bdrv_ref is used anywhere. 05~08 patches calls bdrv_ref for device attach, >> block-migration and nbd. >> >> The rule is: Either bdrv_ref() or bdrv_new() must have a matching >> bdrv_unref() call, and the last matching bdrv_unref deletes the bs. >> >> v4: >> 08: Added, let block job use BDS reference. >> 02: Fix leak of bs.opaque >> >> v3: >> 03: Removed unnecessary bdrv_close() call. >> >> v2: >> 05: Removed: "block: use BlockDriverState refcnt for device attach/detach" >> 07: Fix xen_disk blk_disconnect() as it depended on device attach refcnt. > > Sorry, can't merge this because it breaks qemu-iotests 041 and 055: > > $ ./check -qcow2 055 041 > > Please always run qemu-iotests before submitting patches. > > Stefan > Hi, What is the correct steps to run full qemu-iotests? I modified qemu-iotests-quick.sh as: #!/bin/sh # We don't know which of the system emulator binaries there is (or if there is # any at all), so the 'quick' group doesn't contain any tests that require # running qemu proper. Assign a fake binary name so that qemu-iotests doesn't # complain about the missing binary. export QEMU_PROG="$(pwd)/x86_64-softmmu/qemu-system-x86_64" export QEMU_IMG_PROG="$(pwd)/qemu-img" export QEMU_IO_PROG="$(pwd)/qemu-io" export QEMU_NBD_PROG="$(pwd)/qemu-nbd" cd $SRC_PATH/tests/qemu-iotests ret=0 ./check -T -nocache -qcow2 || ret=1 exit $ret Then make check-block, 026 038 fail, 038 sometimes fail. The code from is upstream, host is RH6.3 @ x86_64. Do I missed some steps? -- Best Regards Wenchao Xia