From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCi8G-0006LG-3V for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:34:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCi83-0006yF-V2 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:33:52 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:52699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCi83-0006xs-D8 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:33:39 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 08:47:36 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 35577E004F for ; Fri, 23 Aug 2013 08:54:00 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7N3P1bn37945538 for ; Fri, 23 Aug 2013 08:55:01 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7N3NSsm024296 for ; Fri, 23 Aug 2013 08:53:28 +0530 Message-ID: <5216D569.9000802@linux.vnet.ibm.com> Date: Fri, 23 Aug 2013 11:22:17 +0800 From: Lei Li MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-7-git-send-email-lilei@linux.vnet.ibm.com> <52149937.4040700@redhat.com> In-Reply-To: <52149937.4040700@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com On 08/21/2013 06:40 PM, Paolo Bonzini wrote: > Il 21/08/2013 09:18, Lei Li ha scritto: >> It should set negative error value if there has been an error. >> >> Signed-off-by: Lei Li >> --- >> savevm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/savevm.c b/savevm.c >> index 1522d95..f10e031 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) >> >> void ram_control_load_hook(QEMUFile *f, uint64_t flags) >> { >> - int ret = 0; >> + int ret = -1; > -EINVAL OK, thanks. > > otherwise looks good thanks! > > Paolo > >> if (f->ops->hook_ram_load) { >> ret = f->ops->hook_ram_load(f, f->opaque, flags); >> > -- Lei