From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCkvZ-0004x8-5m for qemu-devel@nongnu.org; Fri, 23 Aug 2013 02:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCkvQ-0002Rs-7P for qemu-devel@nongnu.org; Fri, 23 Aug 2013 02:32:57 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:34556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCkvP-0002Rf-GN for qemu-devel@nongnu.org; Fri, 23 Aug 2013 02:32:48 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 16:21:11 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id EB2492CE804C for ; Fri, 23 Aug 2013 16:32:25 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7N6WEgW8978852 for ; Fri, 23 Aug 2013 16:32:14 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7N6WOS9003352 for ; Fri, 23 Aug 2013 16:32:25 +1000 Message-ID: <521701AF.8070905@linux.vnet.ibm.com> Date: Fri, 23 Aug 2013 14:31:11 +0800 From: Lei Li MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-7-git-send-email-lilei@linux.vnet.ibm.com> <52149937.4040700@redhat.com> <5216D569.9000802@linux.vnet.ibm.com> <85279077.3140282.1377236094231.JavaMail.root@redhat.com> In-Reply-To: <85279077.3140282.1377236094231.JavaMail.root@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com On 08/23/2013 01:34 PM, Paolo Bonzini wrote: >> On 08/21/2013 06:40 PM, Paolo Bonzini wrote: >>> Il 21/08/2013 09:18, Lei Li ha scritto: >>>> It should set negative error value if there has been an error. >>>> >>>> Signed-off-by: Lei Li >>>> --- >>>> savevm.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/savevm.c b/savevm.c >>>> index 1522d95..f10e031 100644 >>>> --- a/savevm.c >>>> +++ b/savevm.c >>>> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t >>>> flags) >>>> >>>> void ram_control_load_hook(QEMUFile *f, uint64_t flags) >>>> { >>>> - int ret = 0; >>>> + int ret = -1; >>> -EINVAL >> OK, thanks. > Can you extract the patches that I reviewed positively, plus this > one, and send them separately? Sure, I will send it later. :) > > Thanks! > > Paolo > -- Lei