From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCoMf-0000cP-GZ for qemu-devel@nongnu.org; Fri, 23 Aug 2013 06:13:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCoMZ-0000YD-Fi for qemu-devel@nongnu.org; Fri, 23 Aug 2013 06:13:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCoMZ-0000Y8-7h for qemu-devel@nongnu.org; Fri, 23 Aug 2013 06:13:03 -0400 Message-ID: <5217357C.6050307@redhat.com> Date: Fri, 23 Aug 2013 12:12:12 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377252185-25585-1-git-send-email-lilei@linux.vnet.ibm.com> <1377252185-25585-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1377252185-25585-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] savevm: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: lagarcia@br.ibm.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, quintela@redhat.com Il 23/08/2013 12:03, Lei Li ha scritto: > Signed-off-by: Lei Li > --- > savevm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 95a11f9..fb17a6f 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) > > void ram_control_load_hook(QEMUFile *f, uint64_t flags) > { > - int ret = 0; > + int ret = EINVAL; This should be "-EINVAL". Paolo > if (f->ops->hook_ram_load) { > ret = f->ops->hook_ram_load(f, f->opaque, flags); >