From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCpBv-0001wV-ET for qemu-devel@nongnu.org; Fri, 23 Aug 2013 07:06:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCpBp-0003TT-Eq for qemu-devel@nongnu.org; Fri, 23 Aug 2013 07:06:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCpBi-0003SP-7h for qemu-devel@nongnu.org; Fri, 23 Aug 2013 07:06:01 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7NB5p8w012263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Aug 2013 07:05:52 -0400 Message-ID: <5217420C.7060906@redhat.com> Date: Fri, 23 Aug 2013 13:05:48 +0200 From: =?ISO-8859-1?Q?J=E1n_Tomko?= MIME-Version: 1.0 References: <1376904333-30336-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1376904333-30336-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On 08/19/2013 11:25 AM, Kevin Wolf wrote: > By the time that qemu 1.7 will be released, enough time will has passed > since qemu 1.1, which is the first version to understand version 3 > images, that changing the default shouldn't hurt many people any more > and the benefits of using the new format outweigh the pain. > > qemu-iotests already runs with compat=1.1 by default. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 3376901..42ea7ec 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options) > int flags = 0; > size_t cluster_size = DEFAULT_CLUSTER_SIZE; > int prealloc = 0; > - int version = 2; > + int version = 3; > > /* Read out options */ > while (options && options->name) { > This does not affect qemu-img (or bdrv_img_create), as it gets overwritten with 2 when BLOCK_OPT_COMPAT_LEVEL is present in options, but the value is NULL. Should this go into qcow2_create_options[] as well? Jan