From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCqe8-0007SG-8Q for qemu-devel@nongnu.org; Fri, 23 Aug 2013 08:39:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCqdz-00039b-6K for qemu-devel@nongnu.org; Fri, 23 Aug 2013 08:39:20 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:41959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCqdy-00039F-JC for qemu-devel@nongnu.org; Fri, 23 Aug 2013 08:39:11 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 24 Aug 2013 09:33:11 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 1D5582CE804C for ; Fri, 23 Aug 2013 22:38:51 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7NCcZ3062783574 for ; Fri, 23 Aug 2013 22:38:39 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7NCcjCe016925 for ; Fri, 23 Aug 2013 22:38:45 +1000 Message-ID: <5217578C.4050707@linux.vnet.ibm.com> Date: Fri, 23 Aug 2013 20:37:32 +0800 From: Lei Li MIME-Version: 1.0 References: <1377252185-25585-1-git-send-email-lilei@linux.vnet.ibm.com> <1377252185-25585-2-git-send-email-lilei@linux.vnet.ibm.com> <5217357C.6050307@redhat.com> In-Reply-To: <5217357C.6050307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] savevm: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: lagarcia@br.ibm.com, anthony@codemonkey.ws, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, quintela@redhat.com On 08/23/2013 06:12 PM, Paolo Bonzini wrote: > Il 23/08/2013 12:03, Lei Li ha scritto: >> Signed-off-by: Lei Li >> --- >> savevm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/savevm.c b/savevm.c >> index 95a11f9..fb17a6f 100644 >> --- a/savevm.c >> +++ b/savevm.c >> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) >> >> void ram_control_load_hook(QEMUFile *f, uint64_t flags) >> { >> - int ret = 0; >> + int ret = EINVAL; > This should be "-EINVAL". Ooops! Sorry for the rush as I was off line to go home... :-[ Resend soon. > > Paolo > >> if (f->ops->hook_ram_load) { >> ret = f->ops->hook_ram_load(f, f->opaque, flags); >> > -- Lei