From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook()
Date: Fri, 23 Aug 2013 10:18:24 -0400 [thread overview]
Message-ID: <52176F30.3070900@linux.vnet.ibm.com> (raw)
In-Reply-To: <1377264653-31031-2-git-send-email-lilei@linux.vnet.ibm.com>
On 08/23/2013 09:30 AM, Lei Li wrote:
> It should set negative error value if there has been an error.
>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> savevm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 95a11f9..a0be109 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags)
>
> void ram_control_load_hook(QEMUFile *f, uint64_t flags)
> {
> - int ret = 0;
> + int ret = -EINVAL;
>
> if (f->ops->hook_ram_load) {
> ret = f->ops->hook_ram_load(f, f->opaque, flags);
next prev parent reply other threads:[~2013-08-23 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 13:30 [Qemu-devel] [PATCH resend 1/3] savevm: add comments for qemu_file_get_error() Lei Li
2013-08-23 13:30 ` [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook() Lei Li
2013-08-23 14:18 ` Michael R. Hines [this message]
2013-08-23 14:18 ` Michael R. Hines
2013-08-23 13:30 ` [Qemu-devel] [PATCH resend 3/3] arch_init: right return for ram_save_iterate Lei Li
2013-08-26 8:27 ` Paolo Bonzini
2013-08-26 9:22 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52176F30.3070900@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=lilei@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).