From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCsEX-0006uG-18 for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:21:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCsEO-0003tF-3V for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:21:00 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:39728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCsEN-0003t1-Ky for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:20:51 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 08:20:50 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 33EB83E4004F for ; Fri, 23 Aug 2013 08:18:47 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7NEJ1kc187320 for ; Fri, 23 Aug 2013 08:19:02 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7NEIx0O017856 for ; Fri, 23 Aug 2013 08:19:00 -0600 Message-ID: <52176F52.5030103@linux.vnet.ibm.com> Date: Fri, 23 Aug 2013 10:18:58 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1377264653-31031-1-git-send-email-lilei@linux.vnet.ibm.com> <1377264653-31031-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1377264653-31031-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH resend 2/3] savevm: fix wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws On 08/23/2013 09:30 AM, Lei Li wrote: > It should set negative error value if there has been an error. > > Signed-off-by: Lei Li > --- > savevm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 95a11f9..a0be109 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags) > > void ram_control_load_hook(QEMUFile *f, uint64_t flags) > { > - int ret = 0; > + int ret = -EINVAL; > > if (f->ops->hook_ram_load) { > ret = f->ops->hook_ram_load(f, f->opaque, flags); Reviewed-By: Michael R. Hines