From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCtfK-0000nt-Mn for qemu-devel@nongnu.org; Fri, 23 Aug 2013 11:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCtfF-0007BT-Lt for qemu-devel@nongnu.org; Fri, 23 Aug 2013 11:52:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCtfF-0007B5-CG for qemu-devel@nongnu.org; Fri, 23 Aug 2013 11:52:41 -0400 Message-ID: <52178546.6080702@redhat.com> Date: Fri, 23 Aug 2013 17:52:38 +0200 From: Michal Novotny MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, aliguori@us.ibm.com Ping? There are reviews already? Anybody to apply it? Michal On 08/12/2013 06:34 PM, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support required machine type yet (the version > user downgraded to have to have this patch applied too, of course). > > Signed-off-by: Michal Novotny > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/vl.c b/vl.c > index f422a1c..9b4a3f9 100644 > --- a/vl.c > +++ b/vl.c > @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) > if (machine) { > return machine; > } > + > + if (name && !is_help_option(name)) { > + error_report("Unsupported machine type"); > + } > + > printf("Supported machines are:\n"); > for (m = first_machine; m != NULL; m = m->next) { > if (m->alias) { -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org