From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCtuy-0007RA-Vn
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 12:09:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCtut-0000P1-Fv
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 12:08:56 -0400
Message-ID: <52178910.4080500@suse.de>
Date: Fri, 23 Aug 2013 18:08:48 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1377273718-26937-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1377273718-26937-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] scsi: Fix scsi_bus_legacy_add_drive()
 scsi-generic with serial
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: armbru@redhat.com
Cc: pbonzini@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, kraxel@redhat.com

Am 23.08.2013 18:01, schrieb armbru@redhat.com:
> From: Markus Armbruster <armbru@redhat.com>
>=20
> scsi_bus_legacy_add_drive() creates either a scsi-disk or a
> scsi-generic device.  It sets property "serial" to argument serial
> unless null.  Crashes with scsi-generic, because it doesn't have such
> the property.
>=20
> Only usb_msd_initfn_storage() passes non-null serial.  Reproducer:
>=20
>     $ qemu-system-x86_64 -nodefaults -display none -S -usb \
>     -drive if=3Dnone,file=3D/dev/sg1,id=3Dusb-drv0 \
>     -device usb-storage,id=3Dusb-msd0,drive=3Dusb-drv0,serial=3D123
>     qemu-system-x86_64: -device usb-storage,id=3Dusb-msd0,drive=3Dusb-d=
rv0,serial=3D123: Property '.serial' not found
>     Aborted (core dumped)
>=20
> Fix by handling exactly like "removable": set the property only when
> it exists.
>=20
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/scsi/scsi-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg