From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38322)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCuLy-00043a-9g
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 12:36:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCuLs-0000B0-Tz
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 12:36:50 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52100 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCuLs-0000Ap-OJ
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 12:36:44 -0400
Message-ID: <52178F99.20300@suse.de>
Date: Fri, 23 Aug 2013 18:36:41 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20130823162825.GB22101@rox.home.comstyle.com>
In-Reply-To: <20130823162825.GB22101@rox.home.comstyle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Eliminate __packed redefined
	warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Smith <brad@comstyle.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org

Am 23.08.2013 18:28, schrieb Brad Smith:
> This eliminates a warning about __packed being redefined as exposed by =
the
> vmxnet3 code. __packed is not used anywhere in the vmxnet3 code.
>=20
>   CC    hw/net/vmxnet3.o
> In file included from hw/net/vmxnet3.c:29:
> hw/net/vmxnet3.h:37:1: warning: "__packed" redefined
> In file included from /usr/include/stdlib.h:38,
>                  from /buildbot-qemu/default_openbsd_current/build/incl=
ude/qemu-common.h:26,
>                  from /buildbot-qemu/default_openbsd_current/build/incl=
ude/hw/hw.h:5,
>                  from hw/net/vmxnet3.c:18:
> /usr/include/sys/cdefs.h:209:1: warning: this is the location of the pr=
evious definition
>=20
> Signed-off-by: Brad Smith <brad@comstyle.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

CC'ing Stefan as net maintainer.

Andreas

>=20
> diff --git a/hw/net/vmxnet3.h b/hw/net/vmxnet3.h
> index 4eae7c7..f987d71 100644
> --- a/hw/net/vmxnet3.h
> +++ b/hw/net/vmxnet3.h
> @@ -34,7 +34,6 @@
>  #define __le16  uint16_t
>  #define __le32  uint32_t
>  #define __le64  uint64_t
> -#define __packed QEMU_PACKED
> =20
>  #if defined(HOST_WORDS_BIGENDIAN)
>  #define __BIG_ENDIAN_BITFIELD
> @@ -749,7 +748,6 @@ struct Vmxnet3_DriverShared {
>  #undef __le16
>  #undef __le32
>  #undef __le64
> -#undef __packed
>  #if defined(HOST_WORDS_BIGENDIAN)
>  #undef __BIG_ENDIAN_BITFIELD
>  #endif
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg