From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VCwOg-0000re-H7
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:47:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VCwOa-0008Ml-AL
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:47:46 -0400
Message-ID: <5217AE38.3060105@weilnetz.de>
Date: Fri, 23 Aug 2013 20:47:20 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1377279256-4303-1-git-send-email-christoffer.dall@linaro.org>
In-Reply-To: <1377279256-4303-1-git-send-email-christoffer.dall@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] migration: Fix debug print type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, linaro-kernel@lists.linaro.org, qemu-devel@nongnu.org, patches@linaro.org, kvmarm@lists.cs.columbia.edu

Am 23.08.2013 19:34, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed.  Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
>
> [Changelog v1 -> v2]:
>   - Use PRIu64 instead of %llu
>
>  migration.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..e9b83f6 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,8 @@ static void *migration_thread(void *opaque)
>          if (!qemu_file_rate_limit(s->file)) {
>              DPRINTF("iterate\n");
>              pending_size = qemu_savevm_state_pending(s->file, max_size);
> -            DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> +            DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n",
> +                    pending_size, max_size);
>              if (pending_size && pending_size >= max_size) {
>                  qemu_savevm_state_iterate(s->file);
>              } else {

Reviewed-by: Stefan Weil <sw@weilnetz.de>

max_size is not uint64_t but int64_t, so PRId64 would be even better
for that argument, but I don't think this is worth an additional iteration.

CC'ing qemu-trivial, the patch can be applied there.

Regards,
Stefan