From: Richard Henderson <rth@twiddle.net>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: "Andreas Färber" <andreas.faerber@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation
Date: Fri, 23 Aug 2013 12:56:15 -0700 [thread overview]
Message-ID: <5217BE5F.5000708@twiddle.net> (raw)
In-Reply-To: <1377283973-9320-4-git-send-email-hpoussin@reactos.org>
On 08/23/2013 11:52 AM, Hervé Poussineau wrote:
> + uint8_t buf[4];
> + uint64_t val;
> +
> + if (s->contiguous_map == 0) {
> + /* 64 KB contiguous space for IOs */
> + addr &= 0xFFFF;
> + } else {
> + /* 8 MB non-contiguous space for IOs */
> + addr = (addr & 0x1F) | ((addr & 0x007FFF000) >> 7);
> + }
> +
> + address_space_read(&s->pci_io_as, addr + 0x80000000, buf, size);
> + memcpy(&val, buf, size);
> + return val;
This memcpy can't be right, especially for big-endian host.
r~
next prev parent reply other threads:[~2013-08-23 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:52 [Qemu-devel] [PATCH 0/3] prep: improve Raven PCI host emulation Hervé Poussineau
2013-08-23 18:52 ` [Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size Hervé Poussineau
2013-08-23 18:52 ` [Qemu-devel] [PATCH 2/3] prep: kill get_system_io() usage Hervé Poussineau
2013-08-23 18:52 ` [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation Hervé Poussineau
2013-08-23 19:56 ` Richard Henderson [this message]
2013-09-02 20:26 ` Hervé Poussineau
2013-09-02 20:48 ` Peter Maydell
2013-09-02 20:59 ` Peter Maydell
2013-09-02 21:18 ` Hervé Poussineau
2013-09-02 21:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217BE5F.5000708@twiddle.net \
--to=rth@twiddle.net \
--cc=andreas.faerber@web.de \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).