From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxTB-0006da-FF
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 15:56:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxT3-0005p4-1h
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 15:56:29 -0400
Received: from mail-ye0-x22c.google.com ([2607:f8b0:4002:c04::22c]:55769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxT2-0005ov-U2
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 15:56:20 -0400
Received: by mail-ye0-f172.google.com with SMTP id l12so262921yen.17
	for <qemu-devel@nongnu.org>; Fri, 23 Aug 2013 12:56:20 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5217BE5F.5000708@twiddle.net>
Date: Fri, 23 Aug 2013 12:56:15 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1377283973-9320-1-git-send-email-hpoussin@reactos.org>
	<1377283973-9320-4-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1377283973-9320-4-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>, qemu-devel@nongnu.org

On 08/23/2013 11:52 AM, Hervé Poussineau wrote:
> +    uint8_t buf[4];
> +    uint64_t val;
> +
> +    if (s->contiguous_map == 0) {
> +        /* 64 KB contiguous space for IOs */
> +        addr &= 0xFFFF;
> +    } else {
> +        /* 8 MB non-contiguous space for IOs */
> +        addr = (addr & 0x1F) | ((addr & 0x007FFF000) >> 7);
> +    }
> +
> +    address_space_read(&s->pci_io_as, addr + 0x80000000, buf, size);
> +    memcpy(&val, buf, size);
> +    return val;

This memcpy can't be right, especially for big-endian host.


r~