From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VDeLD-0007x4-Uz
	for qemu-devel@nongnu.org; Sun, 25 Aug 2013 13:43:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VDeL7-0007AN-VL
	for qemu-devel@nongnu.org; Sun, 25 Aug 2013 13:43:07 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52571 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VDeL7-0007AI-Oq
	for qemu-devel@nongnu.org; Sun, 25 Aug 2013 13:43:01 -0400
Message-ID: <521A4220.6060004@suse.de>
Date: Sun, 25 Aug 2013 19:42:56 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375709247-10002-1-git-send-email-afaerber@suse.de>
	<1375709247-10002-22-git-send-email-afaerber@suse.de>
	<CAFEAcA9w5LvjZMH=mCXHdDi8sj_m=9hiqQvgFUsr0HjkwjMayg@mail.gmail.com>
In-Reply-To: <CAFEAcA9w5LvjZMH=mCXHdDi8sj_m=9hiqQvgFUsr0HjkwjMayg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM
 machine tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

Am 25.08.2013 19:33, schrieb Peter Maydell:
> On 5 August 2013 14:27, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> +static const char *arm_machines[] =3D {
>> +    "integratorcp",
>> +    "versatilepb",
>> +    "versatileab",
>> +    "lm3s811evb",
>> +    "lm3s6965evb",
>> +    "collie",
>=20
> [etc]
>=20
> I'd rather have these tests than not have them, but can't we autodetect
> the list of machines (by parsing the output of -M help, or otherwise)?

If you want to implement that, feel free to. :) We neither have working
QMP parsing nor a QMP method for obtaining machines that I'm aware of.

My opinion is that if I merge a complete but fixed list today and
afterwards someone adds a new machine and forgets to cover it with
custom or this generic qtest, then it's their fault if I unknowingly
break their machine.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg