From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrAO-0004jy-Ol for qemu-devel@nongnu.org; Mon, 26 Aug 2013 03:24:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDrAG-0000ra-V8 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 03:24:48 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:34455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrAG-0000r9-97 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 03:24:40 -0400 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Aug 2013 12:46:27 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 97A1A1258052 for ; Mon, 26 Aug 2013 12:54:22 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7Q7QAuk35455196 for ; Mon, 26 Aug 2013 12:56:10 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7Q7OTUP005458 for ; Mon, 26 Aug 2013 12:54:29 +0530 Message-ID: <521B025E.7050000@linux.vnet.ibm.com> Date: Mon, 26 Aug 2013 15:23:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1377302436-25193-1-git-send-email-afaerber@suse.de> <1377302436-25193-4-git-send-email-afaerber@suse.de> In-Reply-To: <1377302436-25193-4-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 03/16] ipack: Pass size to ipack_bus_new_inplace() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, anthony@codemonkey.ws > To be passed to qbus_create_inplace(). > > Simplify DEVICE() cast to avoid parent field access. s->dev will always point to pci_dev, so this change is safe. Reviewed-by: Wenchao Xia > > Signed-off-by: Andreas Färber > --- > hw/char/ipack.c | 3 ++- > hw/char/ipack.h | 3 ++- > hw/char/tpci200.c | 2 +- > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/char/ipack.c b/hw/char/ipack.c > index f890471..5fb7073 100644 > --- a/hw/char/ipack.c > +++ b/hw/char/ipack.c > @@ -24,7 +24,8 @@ IPackDevice *ipack_device_find(IPackBus *bus, int32_t slot) > return NULL; > } > > -void ipack_bus_new_inplace(IPackBus *bus, DeviceState *parent, > +void ipack_bus_new_inplace(IPackBus *bus, size_t bus_size, > + DeviceState *parent, > const char *name, uint8_t n_slots, > qemu_irq_handler handler) > { > diff --git a/hw/char/ipack.h b/hw/char/ipack.h > index f2b7a12..f8dc0f2 100644 > --- a/hw/char/ipack.h > +++ b/hw/char/ipack.h > @@ -72,7 +72,8 @@ extern const VMStateDescription vmstate_ipack_device; > VMSTATE_STRUCT(_field, _state, 1, vmstate_ipack_device, IPackDevice) > > IPackDevice *ipack_device_find(IPackBus *bus, int32_t slot); > -void ipack_bus_new_inplace(IPackBus *bus, DeviceState *parent, > +void ipack_bus_new_inplace(IPackBus *bus, size_t bus_size, > + DeviceState *parent, > const char *name, uint8_t n_slots, > qemu_irq_handler handler); > > diff --git a/hw/char/tpci200.c b/hw/char/tpci200.c > index d9e17b2..e04ff26 100644 > --- a/hw/char/tpci200.c > +++ b/hw/char/tpci200.c > @@ -607,7 +607,7 @@ static int tpci200_initfn(PCIDevice *pci_dev) > pci_register_bar(&s->dev, 4, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->las2); > pci_register_bar(&s->dev, 5, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->las3); > > - ipack_bus_new_inplace(&s->bus, DEVICE(&s->dev), NULL, > + ipack_bus_new_inplace(&s->bus, sizeof(s->bus), DEVICE(pci_dev), NULL, > N_MODULES, tpci200_set_irq); > > return 0; > -- Best Regards Wenchao Xia