From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrX0-00062r-JA for qemu-devel@nongnu.org; Mon, 26 Aug 2013 03:48:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDrWv-0000zv-Dn for qemu-devel@nongnu.org; Mon, 26 Aug 2013 03:48:10 -0400 Message-ID: <521B0830.5070209@redhat.com> Date: Mon, 26 Aug 2013 09:48:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377273718-26937-1-git-send-email-armbru@redhat.com> In-Reply-To: <1377273718-26937-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, kraxel@redhat.com Il 23/08/2013 18:01, armbru@redhat.com ha scritto: > From: Markus Armbruster > > scsi_bus_legacy_add_drive() creates either a scsi-disk or a > scsi-generic device. It sets property "serial" to argument serial > unless null. Crashes with scsi-generic, because it doesn't have such > the property. > > Only usb_msd_initfn_storage() passes non-null serial. Reproducer: > > $ qemu-system-x86_64 -nodefaults -display none -S -usb \ > -drive if=none,file=/dev/sg1,id=usb-drv0 \ > -device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123 > qemu-system-x86_64: -device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123: Property '.serial' not found > Aborted (core dumped) > > Fix by handling exactly like "removable": set the property only when > it exists. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Markus Armbruster > --- > hw/scsi/scsi-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index fbf9173..8fe4f4c 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -224,7 +224,7 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockDriverState *bdrv, > if (object_property_find(OBJECT(dev), "removable", NULL)) { > qdev_prop_set_bit(dev, "removable", removable); > } > - if (serial) { > + if (serial && object_property_find(OBJECT(dev), "serial", NULL)) { > qdev_prop_set_string(dev, "serial", serial); > } > if (qdev_prop_set_drive(dev, "drive", bdrv) < 0) { > Applied to scsi-next branch, thanks. Paolo